Re: [PATCH v2] virtgpu: don't reset on shutdown

2025-04-22 Thread Michael S. Tsirkin
On Tue, Apr 22, 2025 at 06:49:04PM +0200, Eric Auger wrote: > Hi Gerd, Michael, > > On 4/16/25 3:57 PM, Gerd Hoffmann wrote: > > On Tue, Apr 15, 2025 at 10:00:48AM -0400, Michael S. Tsirkin wrote: > >> On Tue, Apr 15, 2025 at 01:16:32PM +0200, Gerd Hoffmann wrote: > >>> Hi, > >>> > +static

Re: [PATCH v2] virtgpu: don't reset on shutdown

2025-04-22 Thread Eric Auger
Hi Gerd, Michael, On 4/16/25 3:57 PM, Gerd Hoffmann wrote: > On Tue, Apr 15, 2025 at 10:00:48AM -0400, Michael S. Tsirkin wrote: >> On Tue, Apr 15, 2025 at 01:16:32PM +0200, Gerd Hoffmann wrote: >>> Hi, >>> +static void virtio_gpu_shutdown(struct virtio_device *vdev) +{ + /*

Re: [PATCH v2] virtgpu: don't reset on shutdown

2025-04-21 Thread Gerd Hoffmann
> > diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c > > b/drivers/gpu/drm/virtio/virtgpu_drv.c > > index e32e680c7197..71c6ccad4b99 100644 > > --- a/drivers/gpu/drm/virtio/virtgpu_drv.c > > +++ b/drivers/gpu/drm/virtio/virtgpu_drv.c > > @@ -130,10 +130,10 @@ static void virtio_gpu_remove(struct

Re: [PATCH v2] virtgpu: don't reset on shutdown

2025-04-17 Thread Thomas Zimmermann
Hi Am 16.04.25 um 15:57 schrieb Gerd Hoffmann: On Tue, Apr 15, 2025 at 10:00:48AM -0400, Michael S. Tsirkin wrote: On Tue, Apr 15, 2025 at 01:16:32PM +0200, Gerd Hoffmann wrote: Hi, +static void virtio_gpu_shutdown(struct virtio_device *vdev) +{ + /* +* drm does its own sync

Re: [PATCH v2] virtgpu: don't reset on shutdown

2025-04-16 Thread Gerd Hoffmann
On Tue, Apr 15, 2025 at 10:00:48AM -0400, Michael S. Tsirkin wrote: > On Tue, Apr 15, 2025 at 01:16:32PM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > +static void virtio_gpu_shutdown(struct virtio_device *vdev) > > > +{ > > > + /* > > > + * drm does its own synchronization on shutdown. > > > +

Re: [PATCH v2] virtgpu: don't reset on shutdown

2025-04-15 Thread Michael S. Tsirkin
On Tue, Apr 15, 2025 at 01:16:32PM +0200, Gerd Hoffmann wrote: > Hi, > > > +static void virtio_gpu_shutdown(struct virtio_device *vdev) > > +{ > > + /* > > +* drm does its own synchronization on shutdown. > > +* Do nothing here, opt out of device reset. > > +*/ > > I think a call

Re: [PATCH v2] virtgpu: don't reset on shutdown

2025-04-15 Thread Gerd Hoffmann
Hi, > +static void virtio_gpu_shutdown(struct virtio_device *vdev) > +{ > + /* > + * drm does its own synchronization on shutdown. > + * Do nothing here, opt out of device reset. > + */ I think a call to 'drm_dev_unplug()' is what you need here. take care, Gerd