Re: [PATCH v2] drm/vc4: Expose performance counters to userspace

2018-01-12 Thread Boris Brezillon
On Thu, 11 Jan 2018 16:35:08 -0800 Eric Anholt wrote: > Could we add some docs for get_values? Like: Sure. > > /* > * Returns the values of the performance counters tracked by this > * perfmon (as an array of ncounters u64 values). > * > * No implicit synchronization is performed, so the

Re: [PATCH v2] drm/vc4: Expose performance counters to userspace

2018-01-11 Thread Eric Anholt
Boris Brezillon writes: > The V3D engine has various hardware counters which might be interesting > to userspace performance analysis tools. > > Expose new ioctls to create/destroy a performance monitor object and > query the counter values of this perfmance monitor. > > Note that a perfomance mo