RE: [PATCH v2] drm/amd/amdgpu: cleanup coding style a bit

2020-05-08 Thread Ruhl, Michael J
>-Original Message- >From: dri-devel On Behalf Of >Bernard Zhao >Sent: Thursday, May 7, 2020 5:13 AM >To: Alex Deucher ; Christian König >; David (ChunMing) Zhou >; David Airlie ; Daniel Vetter >; Tom St Denis ; Sam Ravnborg >; Ori Messinger ; Bernard >Zhao ; amd-...@lists.freedesktop.org;

Re: [PATCH v2] drm/amd/amdgpu: cleanup coding style a bit

2020-05-07 Thread Alex Deucher
On Thu, May 7, 2020 at 5:22 AM Christian König wrote: > > Am 07.05.20 um 11:13 schrieb Bernard Zhao: > > There is DEVICE_ATTR mechanism in separate attribute define. > > So this change is to use attr array, also use > > sysfs_create_files in init function & sysfs_remove_files in > > fini function.

Re: [PATCH v2] drm/amd/amdgpu: cleanup coding style a bit

2020-05-07 Thread Christian König
Am 07.05.20 um 11:13 schrieb Bernard Zhao: There is DEVICE_ATTR mechanism in separate attribute define. So this change is to use attr array, also use sysfs_create_files in init function & sysfs_remove_files in fini function. This maybe make the code a bit readable. Signed-off-by: Bernard Zhao