Re: [PATCH v2] Remove custom dumb_map_offset implementation in msm driver

2023-11-27 Thread Dmitry Baryshkov
On Mon, 27 Nov 2023 at 22:52, Rob Clark wrote: > > On Tue, Nov 21, 2023 at 5:14 AM Dmitry Baryshkov > wrote: > > > > On Tue, 21 Nov 2023 at 04:26, Rob Clark wrote: > > > > > > On Wed, Nov 15, 2023 at 11:33 AM Dmitry Baryshkov > > > wrote: > > > > > > > > On Wed, 15 Nov 2023 at 20:46, Dipam Turk

Re: [PATCH v2] Remove custom dumb_map_offset implementation in msm driver

2023-11-27 Thread Rob Clark
On Tue, Nov 21, 2023 at 5:14 AM Dmitry Baryshkov wrote: > > On Tue, 21 Nov 2023 at 04:26, Rob Clark wrote: > > > > On Wed, Nov 15, 2023 at 11:33 AM Dmitry Baryshkov > > wrote: > > > > > > On Wed, 15 Nov 2023 at 20:46, Dipam Turkar wrote: > > > > > > > > They are not outdated, my bad. I went thr

Re: [PATCH v2] Remove custom dumb_map_offset implementation in msm driver

2023-11-21 Thread Dmitry Baryshkov
On Tue, 21 Nov 2023 at 04:26, Rob Clark wrote: > > On Wed, Nov 15, 2023 at 11:33 AM Dmitry Baryshkov > wrote: > > > > On Wed, 15 Nov 2023 at 20:46, Dipam Turkar wrote: > > > > > > They are not outdated, my bad. I went through the locks' code and saw > > > that they have been updated. But they a

Re: [PATCH v2] Remove custom dumb_map_offset implementation in msm driver

2023-11-20 Thread Rob Clark
On Wed, Nov 15, 2023 at 11:33 AM Dmitry Baryshkov wrote: > > On Wed, 15 Nov 2023 at 20:46, Dipam Turkar wrote: > > > > They are not outdated, my bad. I went through the locks' code and saw that > > they have been updated. But they are probably not necessary here as most of > > the drivers do no

Re: [PATCH v2] Remove custom dumb_map_offset implementation in msm driver

2023-11-15 Thread Dmitry Baryshkov
On Wed, 15 Nov 2023 at 20:46, Dipam Turkar wrote: > > They are not outdated, my bad. I went through the locks' code and saw that > they have been updated. But they are probably not necessary here as most of > the drivers do not use any form of locking in their implementations. The > generic imp

Re: [PATCH v2] Remove custom dumb_map_offset implementation in msm driver

2023-11-15 Thread Dipam Turkar
They are not outdated, my bad. I went through the locks' code and saw that they have been updated. But they are probably not necessary here as most of the drivers do not use any form of locking in their implementations. The generic implementations drm_gem_dumb_map_offset() and drm_gem_ttm_dumb_map_

Re: [PATCH v2] Remove custom dumb_map_offset implementation in msm driver

2023-11-15 Thread Dipam Turkar
They are not outdated, my bad. I went through the locks' code and saw that they have been updated. But they are probably not necessary here as most of the drivers do not use any form of locking in their implementations. The generic implementations drm_gem_dumb_map_offset() and drm_gem_ttm_dumb_map_

Re: [PATCH v2] Remove custom dumb_map_offset implementation in msm driver

2023-11-15 Thread Dmitry Baryshkov
On Wed, 15 Nov 2023 at 16:30, Dipam Turkar wrote: > > Make msm use drm_gem_create_map_offset() instead of its custom > implementation for associating GEM object with a fake offset. Since, > we already have this generic implementation, we don't need the custom > implementation and it is better to s