Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-12-14 Thread Dmitry Osipenko
On 12/14/23 21:16, Maxime Ripard wrote: > On Tue, Dec 05, 2023 at 02:43:16PM +0300, Dmitry Osipenko wrote: >> On 12/4/23 15:55, Maxime Ripard wrote: Okay, that means s/_locked/_nolock/ in drm_gem_shmem_helpers.{c,h}, I guess. >> >> DRM subsys and majority of kernel uses common _locked pos

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-12-14 Thread Maxime Ripard
On Tue, Dec 05, 2023 at 02:43:16PM +0300, Dmitry Osipenko wrote: > On 12/4/23 15:55, Maxime Ripard wrote: > >> Okay, that means s/_locked/_nolock/ in drm_gem_shmem_helpers.{c,h}, I > >> guess. > > DRM subsys and majority of kernel uses common _locked postfix. We should > retain the old naming sche

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-12-05 Thread Dmitry Osipenko
On 12/4/23 15:55, Maxime Ripard wrote: >> Okay, that means s/_locked/_nolock/ in drm_gem_shmem_helpers.{c,h}, I >> guess. DRM subsys and majority of kernel uses common _locked postfix. We should retain the old naming scheme by using _locked() in DRM. It's not worthwhile changing the name to a much

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-12-04 Thread Maxime Ripard
On Wed, Nov 29, 2023 at 04:47:05PM +0100, Boris Brezillon wrote: > On Wed, 29 Nov 2023 16:15:27 +0100 > Maxime Ripard wrote: > > > > Now, let's assume we drop the _locked() suffix on > > > drm_gem_shmem_v[un]map(), but keep it on other helpers that need both > > > variants. This results in an inc

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-29 Thread Boris Brezillon
On Wed, 29 Nov 2023 16:15:27 +0100 Maxime Ripard wrote: > > Now, let's assume we drop the _locked() suffix on > > drm_gem_shmem_v[un]map(), but keep it on other helpers that need both > > variants. This results in an inconsistent naming scheme inside the > > same source file, which I find utterly

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-29 Thread Maxime Ripard
On Wed, Nov 29, 2023 at 02:46:09PM +0100, Boris Brezillon wrote: > On Wed, 29 Nov 2023 14:09:47 +0100 > Maxime Ripard wrote: > > > On Wed, Nov 29, 2023 at 08:53:30AM +0100, Boris Brezillon wrote: > > > On Wed, 29 Nov 2023 01:05:14 +0300 > > > Dmitry Osipenko wrote: > > > > > > > On 11/28/23 1

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-29 Thread Boris Brezillon
On Wed, 29 Nov 2023 14:09:47 +0100 Maxime Ripard wrote: > On Wed, Nov 29, 2023 at 08:53:30AM +0100, Boris Brezillon wrote: > > On Wed, 29 Nov 2023 01:05:14 +0300 > > Dmitry Osipenko wrote: > > > > > On 11/28/23 15:37, Boris Brezillon wrote: > > > > On Tue, 28 Nov 2023 12:14:42 +0100 > > > >

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-29 Thread Maxime Ripard
On Wed, Nov 29, 2023 at 08:53:30AM +0100, Boris Brezillon wrote: > On Wed, 29 Nov 2023 01:05:14 +0300 > Dmitry Osipenko wrote: > > > On 11/28/23 15:37, Boris Brezillon wrote: > > > On Tue, 28 Nov 2023 12:14:42 +0100 > > > Maxime Ripard wrote: > > > > > >> Hi, > > >> > > >> On Fri, Nov 24, 202

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-29 Thread Boris Brezillon
On Wed, 29 Nov 2023 13:47:21 +0300 Dmitry Osipenko wrote: > On 11/29/23 10:53, Boris Brezillon wrote: > > On Wed, 29 Nov 2023 01:05:14 +0300 > > Dmitry Osipenko wrote: > > > >> On 11/28/23 15:37, Boris Brezillon wrote: > >>> On Tue, 28 Nov 2023 12:14:42 +0100 > >>> Maxime Ripard wrote: > >

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-29 Thread Dmitry Osipenko
On 11/29/23 10:53, Boris Brezillon wrote: > On Wed, 29 Nov 2023 01:05:14 +0300 > Dmitry Osipenko wrote: > >> On 11/28/23 15:37, Boris Brezillon wrote: >>> On Tue, 28 Nov 2023 12:14:42 +0100 >>> Maxime Ripard wrote: >>> Hi, On Fri, Nov 24, 2023 at 11:59:11AM +0100, Boris Brezill

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-28 Thread Boris Brezillon
On Wed, 29 Nov 2023 01:05:14 +0300 Dmitry Osipenko wrote: > On 11/28/23 15:37, Boris Brezillon wrote: > > On Tue, 28 Nov 2023 12:14:42 +0100 > > Maxime Ripard wrote: > > > >> Hi, > >> > >> On Fri, Nov 24, 2023 at 11:59:11AM +0100, Boris Brezillon wrote: > >>> On Fri, 24 Nov 2023 11:40:06 +0

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-28 Thread Dmitry Osipenko
On 11/28/23 15:37, Boris Brezillon wrote: > On Tue, 28 Nov 2023 12:14:42 +0100 > Maxime Ripard wrote: > >> Hi, >> >> On Fri, Nov 24, 2023 at 11:59:11AM +0100, Boris Brezillon wrote: >>> On Fri, 24 Nov 2023 11:40:06 +0100 >>> Maxime Ripard wrote: >>> On Mon, Oct 30, 2023 at 02:01:43AM +03

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-28 Thread Boris Brezillon
On Tue, 28 Nov 2023 12:14:42 +0100 Maxime Ripard wrote: > Hi, > > On Fri, Nov 24, 2023 at 11:59:11AM +0100, Boris Brezillon wrote: > > On Fri, 24 Nov 2023 11:40:06 +0100 > > Maxime Ripard wrote: > > > > > On Mon, Oct 30, 2023 at 02:01:43AM +0300, Dmitry Osipenko wrote: > > > > Add locked a

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-28 Thread Maxime Ripard
Hi, On Fri, Nov 24, 2023 at 11:59:11AM +0100, Boris Brezillon wrote: > On Fri, 24 Nov 2023 11:40:06 +0100 > Maxime Ripard wrote: > > > On Mon, Oct 30, 2023 at 02:01:43AM +0300, Dmitry Osipenko wrote: > > > Add locked and remove unlocked postfixes from drm-shmem function names, > > > making names

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-24 Thread Boris Brezillon
On Fri, 24 Nov 2023 11:40:06 +0100 Maxime Ripard wrote: > On Mon, Oct 30, 2023 at 02:01:43AM +0300, Dmitry Osipenko wrote: > > Add locked and remove unlocked postfixes from drm-shmem function names, > > making names consistent with the drm/gem core code. > > > > Reviewed-by: Boris Brezillon > >

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-24 Thread Boris Brezillon
On Fri, 24 Nov 2023 11:40:06 +0100 Maxime Ripard wrote: > On Mon, Oct 30, 2023 at 02:01:43AM +0300, Dmitry Osipenko wrote: > > Add locked and remove unlocked postfixes from drm-shmem function names, > > making names consistent with the drm/gem core code. > > > > Reviewed-by: Boris Brezillon > >

Re: [PATCH v18 04/26] drm/shmem-helper: Refactor locked/unlocked functions

2023-11-24 Thread Maxime Ripard
On Mon, Oct 30, 2023 at 02:01:43AM +0300, Dmitry Osipenko wrote: > Add locked and remove unlocked postfixes from drm-shmem function names, > making names consistent with the drm/gem core code. > > Reviewed-by: Boris Brezillon > Suggested-by: Boris Brezillon > Signed-off-by: Dmitry Osipenko Thi