Re: [PATCH v14 RESEND 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2023-10-03 Thread Maxime Ripard
On Tue, Sep 26, 2023 at 03:55:35AM +, Ying Liu wrote: > > > > > + cf->pec_base = devm_ioremap(dpu->dev, pec_base, SZ_16); > > > > > + if (!cf->pec_base) > > > > > + return -ENOMEM; > > > > > + > > > > > + cf->base = devm_ioremap(dpu->dev, base, SZ_32); > > > > > + if

RE: [PATCH v14 RESEND 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2023-09-25 Thread Ying Liu
On Tuesday, September 5, 2023 4:37 PM, Maxime Ripard wrote: > On Tue, Sep 05, 2023 at 03:32:47AM +, Ying Liu wrote: > > > On Tue, Aug 22, 2023 at 04:59:48PM +0800, Liu Ying wrote: > > > > +int dpu_cf_init(struct dpu_soc *dpu, unsigned int index, > > > > + unsigned int id, enum dp

Re: [PATCH v14 RESEND 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2023-09-05 Thread Maxime Ripard
On Tue, Sep 05, 2023 at 03:32:47AM +, Ying Liu wrote: > > On Tue, Aug 22, 2023 at 04:59:48PM +0800, Liu Ying wrote: > > > +int dpu_cf_init(struct dpu_soc *dpu, unsigned int index, > > > + unsigned int id, enum dpu_unit_type type, > > > + unsigned long pec_base, unsigned long bas

RE: [PATCH v14 RESEND 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2023-09-04 Thread Ying Liu
On Tuesday, August 22, 2023 8:59 PM, Maxime Ripard wrote: > > Hi, Hi, > > Aside from the discussion on the binding and the general architecture, I > have some comments there. Thanks for your comments. > > On Tue, Aug 22, 2023 at 04:59:48PM +0800, Liu Ying wrote: > > +int dpu_cf_init(struct

Re: [PATCH v14 RESEND 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2023-08-22 Thread Maxime Ripard
Hi, Aside from the discussion on the binding and the general architecture, I have some comments there. On Tue, Aug 22, 2023 at 04:59:48PM +0800, Liu Ying wrote: > +int dpu_cf_init(struct dpu_soc *dpu, unsigned int index, > + unsigned int id, enum dpu_unit_type type, > + un