Re: [PATCH v10 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2020-04-09 Thread Sam Ravnborg
Hi Guido. > > > + > > > +/* i.MX8 NWL quirks */ > > > +/* i.MX8MQ errata E11418 */ > > > +#define E11418_HS_MODE_QUIRK BIT(0) > > > + > > > +#define NWL_DSI_MIPI_FIFO_TIMEOUT msecs_to_jiffies(500) > > Should the defines be moved to the header file? > > I've used this rules: register layout (t

Re: [PATCH v10 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2020-04-09 Thread Guido Günther
Hi Sam, Thanks for having a look! Comments below: On Wed, Apr 08, 2020 at 07:52:52PM +0200, Sam Ravnborg wrote: > Hi Guido. > > On Fri, Mar 20, 2020 at 07:49:10PM +0100, Guido Günther wrote: > > This adds initial support for the NWL MIPI DSI Host controller found on > > i.MX8 SoCs. > > > > It ad

Re: [PATCH v10 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2020-04-08 Thread Sam Ravnborg
Hi Guido. On Fri, Mar 20, 2020 at 07:49:10PM +0100, Guido Günther wrote: > This adds initial support for the NWL MIPI DSI Host controller found on > i.MX8 SoCs. > > It adds support for the i.MX8MQ but the same IP can be found on > e.g. the i.MX8QXP. > > It has been tested on the Librem 5 devkit

Re: [PATCH v10 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2020-03-24 Thread Fabio Estevam
On Fri, Mar 20, 2020 at 3:49 PM Guido Günther wrote: > > This adds initial support for the NWL MIPI DSI Host controller found on > i.MX8 SoCs. > > It adds support for the i.MX8MQ but the same IP can be found on > e.g. the i.MX8QXP. > > It has been tested on the Librem 5 devkit using mxsfb. > > Sig