Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-23 Thread Ekansh Gupta
On 1/23/2025 6:03 PM, Dmitry Baryshkov wrote: > On Thu, Jan 23, 2025 at 05:34:00PM +0530, Ekansh Gupta wrote: >> >> >> On 1/23/2025 4:43 PM, Dmitry Baryshkov wrote: >>> On Thu, Jan 23, 2025 at 03:19:21PM +0530, Ekansh Gupta wrote: On 1/23/2025 1:18 PM, Dmitry Baryshkov wrote: > On

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-23 Thread Dmitry Baryshkov
On Thu, Jan 23, 2025 at 05:34:00PM +0530, Ekansh Gupta wrote: > > > > On 1/23/2025 4:43 PM, Dmitry Baryshkov wrote: > > On Thu, Jan 23, 2025 at 03:19:21PM +0530, Ekansh Gupta wrote: > >> > >> > >> On 1/23/2025 1:18 PM, Dmitry Baryshkov wrote: > >>> On Thu, Jan 23, 2025 at 11:16:41AM +0530, Ekans

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-23 Thread Ekansh Gupta
On 1/23/2025 4:43 PM, Dmitry Baryshkov wrote: > On Thu, Jan 23, 2025 at 03:19:21PM +0530, Ekansh Gupta wrote: >> >> >> On 1/23/2025 1:18 PM, Dmitry Baryshkov wrote: >>> On Thu, Jan 23, 2025 at 11:16:41AM +0530, Ekansh Gupta wrote: On 10/7/2024 7:27 PM, Dmitry Baryshkov wrote: > On

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-23 Thread Dmitry Baryshkov
On Thu, Jan 23, 2025 at 03:19:21PM +0530, Ekansh Gupta wrote: > > > > On 1/23/2025 1:18 PM, Dmitry Baryshkov wrote: > > On Thu, Jan 23, 2025 at 11:16:41AM +0530, Ekansh Gupta wrote: > >> > >> > >> On 10/7/2024 7:27 PM, Dmitry Baryshkov wrote: > >>> On Mon, Oct 07, 2024 at 02:15:15PM GMT, Ekansh

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-23 Thread Ekansh Gupta
On 1/23/2025 1:18 PM, Dmitry Baryshkov wrote: > On Thu, Jan 23, 2025 at 11:16:41AM +0530, Ekansh Gupta wrote: >> >> >> On 10/7/2024 7:27 PM, Dmitry Baryshkov wrote: >>> On Mon, Oct 07, 2024 at 02:15:15PM GMT, Ekansh Gupta wrote: InvokeV2 request is intended to support multiple enhanced inv

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-22 Thread Dmitry Baryshkov
On Thu, Jan 23, 2025 at 11:16:41AM +0530, Ekansh Gupta wrote: > > > > On 10/7/2024 7:27 PM, Dmitry Baryshkov wrote: > > On Mon, Oct 07, 2024 at 02:15:15PM GMT, Ekansh Gupta wrote: > >> InvokeV2 request is intended to support multiple enhanced invoke > >> requests like CRC check, performance coun

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2025-01-22 Thread Ekansh Gupta
On 10/7/2024 7:27 PM, Dmitry Baryshkov wrote: > On Mon, Oct 07, 2024 at 02:15:15PM GMT, Ekansh Gupta wrote: >> InvokeV2 request is intended to support multiple enhanced invoke >> requests like CRC check, performance counter enablement and polling >> mode for RPC invocations. CRC check is gettin

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2024-10-09 Thread Ekansh Gupta
On 10/7/2024 2:23 PM, Greg KH wrote: > On Mon, Oct 07, 2024 at 02:15:15PM +0530, Ekansh Gupta wrote: >> +struct fastrpc_invoke_v2 { >> +struct fastrpc_invoke inv; >> +__u64 crc; >> +__u32 reserved[16]; > I'm sure we have been over this before, but if you have a reserved > field, you

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2024-10-08 Thread kernel test robot
Hi Ekansh, kernel test robot noticed the following build warnings: [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.12-rc2 next-20241008] [If your patch is applied to the wrong git tree, kindly

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2024-10-07 Thread kernel test robot
Hi Ekansh, kernel test robot noticed the following build errors: [auto build test ERROR on char-misc/char-misc-testing] [also build test ERROR on char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.12-rc2 next-20241004] [If your patch is applied to the wrong git tree, kindly drop

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2024-10-07 Thread kernel test robot
Hi Ekansh, kernel test robot noticed the following build errors: [auto build test ERROR on char-misc/char-misc-testing] [also build test ERROR on char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.12-rc2 next-20241004] [If your patch is applied to the wrong git tree, kindly drop

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2024-10-07 Thread kernel test robot
Hi Ekansh, kernel test robot noticed the following build warnings: [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.12-rc2 next-20241004] [If your patch is applied to the wrong git tree, kindly

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2024-10-07 Thread Dmitry Baryshkov
On Mon, Oct 07, 2024 at 02:15:15PM GMT, Ekansh Gupta wrote: > InvokeV2 request is intended to support multiple enhanced invoke > requests like CRC check, performance counter enablement and polling > mode for RPC invocations. CRC check is getting enabled as part of > this patch. CRC check for input

Re: [PATCH v1 1/4] misc: fastrpc: Add CRC support using invokeV2 request

2024-10-07 Thread Greg KH
On Mon, Oct 07, 2024 at 02:15:15PM +0530, Ekansh Gupta wrote: > +struct fastrpc_invoke_v2 { > + struct fastrpc_invoke inv; > + __u64 crc; > + __u32 reserved[16]; I'm sure we have been over this before, but if you have a reserved field, you HAVE to check that it is zero if you ever want