Re: [PATCH hmm 3/6] mm/hmm: remove unused code and tidy comments

2020-03-24 Thread Jason Gunthorpe
On Fri, Mar 20, 2020 at 02:46:09PM -0700, Ralph Campbell wrote: > > On 3/20/20 9:49 AM, Jason Gunthorpe wrote: > > From: Jason Gunthorpe > > > > Delete several functions that are never called, fix some desync between > > comments and structure content, remove an unused ret, and move one > > func

Re: [PATCH hmm 3/6] mm/hmm: remove unused code and tidy comments

2020-03-24 Thread Jason Gunthorpe
On Sat, Mar 21, 2020 at 09:39:02AM +0100, Christoph Hellwig wrote: > On Fri, Mar 20, 2020 at 01:49:02PM -0300, Jason Gunthorpe wrote: > > From: Jason Gunthorpe > > > > Delete several functions that are never called, fix some desync between > > comments and structure content, remove an unused ret,

Re: [PATCH hmm 3/6] mm/hmm: remove unused code and tidy comments

2020-03-20 Thread Ralph Campbell
On 3/20/20 9:49 AM, Jason Gunthorpe wrote: From: Jason Gunthorpe Delete several functions that are never called, fix some desync between comments and structure content, remove an unused ret, and move one function only used by hmm.c into hmm.c Signed-off-by: Jason Gunthorpe Reviewed-by: Ra