Re: [PATCH V3 2/4] backlight: qcom-wled: Add callback functions

2020-03-24 Thread kgunda
On 2020-03-11 16:00, Daniel Thompson wrote: On Wed, Mar 11, 2020 at 12:11:00PM +0530, kgu...@codeaurora.org wrote: On 2020-03-10 20:57, Daniel Thompson wrote: > On Mon, Mar 09, 2020 at 06:56:00PM +0530, Kiran Gunda wrote: > > Add cabc_config, sync_toggle, wled_ovp_fault_status and wled_ovp_delay

Re: [PATCH V3 2/4] backlight: qcom-wled: Add callback functions

2020-03-11 Thread Daniel Thompson
On Wed, Mar 11, 2020 at 12:11:00PM +0530, kgu...@codeaurora.org wrote: > On 2020-03-10 20:57, Daniel Thompson wrote: > > On Mon, Mar 09, 2020 at 06:56:00PM +0530, Kiran Gunda wrote: > > > Add cabc_config, sync_toggle, wled_ovp_fault_status and wled_ovp_delay > > > callback functions to prepare the

Re: [PATCH V3 2/4] backlight: qcom-wled: Add callback functions

2020-03-11 Thread kgunda
On 2020-03-10 20:57, Daniel Thompson wrote: On Mon, Mar 09, 2020 at 06:56:00PM +0530, Kiran Gunda wrote: Add cabc_config, sync_toggle, wled_ovp_fault_status and wled_ovp_delay callback functions to prepare the driver for adding WLED5 support. Signed-off-by: Kiran Gunda Overall this code woul

Re: [PATCH V3 2/4] backlight: qcom-wled: Add callback functions

2020-03-10 Thread Daniel Thompson
On Mon, Mar 09, 2020 at 06:56:00PM +0530, Kiran Gunda wrote: > Add cabc_config, sync_toggle, wled_ovp_fault_status and wled_ovp_delay > callback functions to prepare the driver for adding WLED5 support. > > Signed-off-by: Kiran Gunda Overall this code would a lot easier to review if > --- > dri