On Sun, Jul 26, 2020 at 01:12:06PM +0200, Konrad Dybcio wrote:
> From: Xiaozhe Shi
>
> Add the REVID device driver. The REVID driver will print out the PMIC
> revision at probe time.
>
> Signed-off-by: Xiaozhe Shi
> [konradyb...@gmail.com: Fast-forward the driver from kernel 4.14 to 5.8,
> conv
On Sun, 26 Jul 2020 13:12:06 +0200, Konrad Dybcio wrote:
> From: Xiaozhe Shi
>
> Add the REVID device driver. The REVID driver will print out the PMIC
> revision at probe time.
>
> Signed-off-by: Xiaozhe Shi
> [konradyb...@gmail.com: Fast-forward the driver from kernel 4.14 to 5.8,
> convert bi
Hi Greg, thanks for your review!
>Why do we need this noise in the kernel log?
I guess it could be left there as a debug print? Knowing your hardware
revision seems like a good, but yeah, not a necessary thing.
>You can drop the GPL boilerplate text and add a proper SPDX line at the
>top.
Seems
On Sun, Jul 26, 2020 at 01:40:46PM +0200, Konrad Dybcio wrote:
> >Horrible global symbol name. Who calls this?
>
> Welcome to development on qcom platforms :D
Yeah, I have seen :(
> >This is the last patch in
> >the series, so if there is no user for this, please don't export it.
>
> Other dow
On Sun, Jul 26, 2020 at 01:12:06PM +0200, Konrad Dybcio wrote:
> From: Xiaozhe Shi
>
> Add the REVID device driver. The REVID driver will print out the PMIC
> revision at probe time.
Why do we need this noise in the kernel log?
> --- /dev/null
> +++ b/drivers/soc/qcom/qpnp-revid.c
> @@ -0,0 +1,
