Re: [PATCH 3/5] drm/vmwgfx: use core drm to extend/check vmw_execbuf_ioctl

2019-05-24 Thread Thomas Hellstrom
On 5/24/19 12:53 PM, Emil Velikov wrote: On 2019/05/24, Daniel Vetter wrote: On Fri, May 24, 2019 at 8:05 AM Thomas Hellstrom wrote: On Wed, 2019-05-22 at 21:09 +0200, Daniel Vetter wrote: On Wed, May 22, 2019 at 9:01 PM Thomas Hellstrom < thellst...@vmware.com> wrote: Hi, Emil, On Wed, 201

Re: [PATCH 3/5] drm/vmwgfx: use core drm to extend/check vmw_execbuf_ioctl

2019-05-24 Thread Emil Velikov
On 2019/05/24, Daniel Vetter wrote: > On Fri, May 24, 2019 at 8:05 AM Thomas Hellstrom > wrote: > > > > On Wed, 2019-05-22 at 21:09 +0200, Daniel Vetter wrote: > > > On Wed, May 22, 2019 at 9:01 PM Thomas Hellstrom < > > > thellst...@vmware.com> wrote: > > > > Hi, Emil, > > > > > > > > On Wed, 20

Re: [PATCH 3/5] drm/vmwgfx: use core drm to extend/check vmw_execbuf_ioctl

2019-05-24 Thread Daniel Vetter
On Fri, May 24, 2019 at 8:05 AM Thomas Hellstrom wrote: > > On Wed, 2019-05-22 at 21:09 +0200, Daniel Vetter wrote: > > On Wed, May 22, 2019 at 9:01 PM Thomas Hellstrom < > > thellst...@vmware.com> wrote: > > > Hi, Emil, > > > > > > On Wed, 2019-05-22 at 17:41 +0100, Emil Velikov wrote: > > > > Fr

Re: [PATCH 3/5] drm/vmwgfx: use core drm to extend/check vmw_execbuf_ioctl

2019-05-23 Thread Thomas Hellstrom
On Wed, 2019-05-22 at 21:09 +0200, Daniel Vetter wrote: > On Wed, May 22, 2019 at 9:01 PM Thomas Hellstrom < > thellst...@vmware.com> wrote: > > Hi, Emil, > > > > On Wed, 2019-05-22 at 17:41 +0100, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > Currently vmw_execbuf_ioctl() open-codes

Re: [PATCH 3/5] drm/vmwgfx: use core drm to extend/check vmw_execbuf_ioctl

2019-05-23 Thread Thomas Hellstrom
On Wed, 2019-05-22 at 17:41 +0100, Emil Velikov wrote: > From: Emil Velikov > > Currently vmw_execbuf_ioctl() open-codes the permission checking, > size > extending and copying that is already done in core drm. > > Kill all the duplication, adding a few comments for clarity. > > Cc: "VMware Gra

Re: [PATCH 3/5] drm/vmwgfx: use core drm to extend/check vmw_execbuf_ioctl

2019-05-22 Thread Daniel Vetter
On Wed, May 22, 2019 at 9:01 PM Thomas Hellstrom wrote: > > Hi, Emil, > > On Wed, 2019-05-22 at 17:41 +0100, Emil Velikov wrote: > > From: Emil Velikov > > > > Currently vmw_execbuf_ioctl() open-codes the permission checking, > > size > > extending and copying that is already done in core drm. >

Re: [PATCH 3/5] drm/vmwgfx: use core drm to extend/check vmw_execbuf_ioctl

2019-05-22 Thread Thomas Hellstrom
Hi, Emil, On Wed, 2019-05-22 at 17:41 +0100, Emil Velikov wrote: > From: Emil Velikov > > Currently vmw_execbuf_ioctl() open-codes the permission checking, > size > extending and copying that is already done in core drm. > > Kill all the duplication, adding a few comments for clarity. Ah, ther