Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-23 Thread Danilo Krummrich
On Wed, Apr 23, 2025 at 11:10:51AM +0100, Tvrtko Ursulin wrote: > > On 23/04/2025 09:48, Danilo Krummrich wrote: > > On Wed, Apr 23, 2025 at 08:34:08AM +0100, Tvrtko Ursulin wrote: > > > > > > IMO it is better to leave it. Regardless of whether it was added because > > > some driver is actually o

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-23 Thread Tvrtko Ursulin
On 23/04/2025 09:48, Danilo Krummrich wrote: On Wed, Apr 23, 2025 at 08:34:08AM +0100, Tvrtko Ursulin wrote: IMO it is better to leave it. Regardless of whether it was added because some driver is actually operating like that, it does describe a _currently_ workable option to avoid memory lea

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-23 Thread Danilo Krummrich
On Wed, Apr 23, 2025 at 08:34:08AM +0100, Tvrtko Ursulin wrote: > > IMO it is better to leave it. Regardless of whether it was added because > some driver is actually operating like that, it does describe a _currently_ > workable option to avoid memory leaks. Once a better method is there, ie. > F

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-23 Thread Tvrtko Ursulin
On 22/04/2025 15:52, Danilo Krummrich wrote: On Tue, Apr 22, 2025 at 04:16:48PM +0200, Philipp Stanner wrote: On Tue, 2025-04-22 at 16:08 +0200, Danilo Krummrich wrote: On Tue, Apr 22, 2025 at 02:39:21PM +0100, Tvrtko Ursulin wrote: Sorry I don't see the argument for the claim it is relyin

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-22 Thread Danilo Krummrich
On Tue, Apr 22, 2025 at 04:16:48PM +0200, Philipp Stanner wrote: > On Tue, 2025-04-22 at 16:08 +0200, Danilo Krummrich wrote: > > On Tue, Apr 22, 2025 at 02:39:21PM +0100, Tvrtko Ursulin wrote: > > > > Sorry I don't see the argument for the claim it is relying on the > > > internals > > > with the

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-22 Thread Philipp Stanner
On Tue, 2025-04-22 at 16:08 +0200, Danilo Krummrich wrote: > On Tue, Apr 22, 2025 at 02:39:21PM +0100, Tvrtko Ursulin wrote: > > > > On 22/04/2025 13:32, Danilo Krummrich wrote: > > > On Tue, Apr 22, 2025 at 01:07:47PM +0100, Tvrtko Ursulin wrote: > > > > > > > > On 22/04/2025 12:13, Danilo Krumm

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-22 Thread Danilo Krummrich
On Tue, Apr 22, 2025 at 02:39:21PM +0100, Tvrtko Ursulin wrote: > > On 22/04/2025 13:32, Danilo Krummrich wrote: > > On Tue, Apr 22, 2025 at 01:07:47PM +0100, Tvrtko Ursulin wrote: > > > > > > On 22/04/2025 12:13, Danilo Krummrich wrote: > > > > On Tue, Apr 22, 2025 at 11:39:11AM +0100, Tvrtko Ur

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-22 Thread Philipp Stanner
On Tue, 2025-04-22 at 14:39 +0100, Tvrtko Ursulin wrote: > > On 22/04/2025 13:32, Danilo Krummrich wrote: > > On Tue, Apr 22, 2025 at 01:07:47PM +0100, Tvrtko Ursulin wrote: > > > > > > On 22/04/2025 12:13, Danilo Krummrich wrote: > > > > On Tue, Apr 22, 2025 at 11:39:11AM +0100, Tvrtko Ursulin w

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-22 Thread Tvrtko Ursulin
On 22/04/2025 13:32, Danilo Krummrich wrote: On Tue, Apr 22, 2025 at 01:07:47PM +0100, Tvrtko Ursulin wrote: On 22/04/2025 12:13, Danilo Krummrich wrote: On Tue, Apr 22, 2025 at 11:39:11AM +0100, Tvrtko Ursulin wrote: Question I raised is if there are other drivers which manage to clean up

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-22 Thread Tvrtko Ursulin
On 22/04/2025 13:00, Philipp Stanner wrote: On Tue, 2025-04-22 at 13:13 +0200, Danilo Krummrich wrote: On Tue, Apr 22, 2025 at 11:39:11AM +0100, Tvrtko Ursulin wrote: Question I raised is if there are other drivers which manage to clean up everything correctly (like the mock scheduler does),

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-22 Thread Danilo Krummrich
On Tue, Apr 22, 2025 at 01:07:47PM +0100, Tvrtko Ursulin wrote: > > On 22/04/2025 12:13, Danilo Krummrich wrote: > > On Tue, Apr 22, 2025 at 11:39:11AM +0100, Tvrtko Ursulin wrote: > > > Question I raised is if there are other drivers which manage to clean up > > > everything correctly (like the m

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-22 Thread Philipp Stanner
On Tue, 2025-04-22 at 13:07 +0100, Tvrtko Ursulin wrote: > > On 22/04/2025 12:13, Danilo Krummrich wrote: > > On Tue, Apr 22, 2025 at 11:39:11AM +0100, Tvrtko Ursulin wrote: > > > Question I raised is if there are other drivers which manage to > > > clean up > > > everything correctly (like the mo

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-22 Thread Tvrtko Ursulin
On 22/04/2025 12:13, Danilo Krummrich wrote: On Tue, Apr 22, 2025 at 11:39:11AM +0100, Tvrtko Ursulin wrote: Question I raised is if there are other drivers which manage to clean up everything correctly (like the mock scheduler does), but trigger that warning. Maybe there are not and maybe moc

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-22 Thread Philipp Stanner
On Tue, 2025-04-22 at 13:13 +0200, Danilo Krummrich wrote: > On Tue, Apr 22, 2025 at 11:39:11AM +0100, Tvrtko Ursulin wrote: > > Question I raised is if there are other drivers which manage to > > clean up > > everything correctly (like the mock scheduler does), but trigger > > that > > warning. Ma

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-22 Thread Danilo Krummrich
On Tue, Apr 22, 2025 at 11:39:11AM +0100, Tvrtko Ursulin wrote: > Question I raised is if there are other drivers which manage to clean up > everything correctly (like the mock scheduler does), but trigger that > warning. Maybe there are not and maybe mock scheduler is the only false > positive. S

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-22 Thread Tvrtko Ursulin
On 22/04/2025 07:06, Philipp Stanner wrote: On Thu, 2025-04-17 at 17:08 +0100, Tvrtko Ursulin wrote: On 17/04/2025 15:48, Danilo Krummrich wrote: On Thu, Apr 17, 2025 at 03:20:44PM +0100, Tvrtko Ursulin wrote: On 17/04/2025 13:11, Danilo Krummrich wrote: On Thu, Apr 17, 2025 at 12:27:29PM

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-21 Thread Philipp Stanner
On Thu, 2025-04-17 at 17:08 +0100, Tvrtko Ursulin wrote: > > On 17/04/2025 15:48, Danilo Krummrich wrote: > > On Thu, Apr 17, 2025 at 03:20:44PM +0100, Tvrtko Ursulin wrote: > > > > > > On 17/04/2025 13:11, Danilo Krummrich wrote: > > > > On Thu, Apr 17, 2025 at 12:27:29PM +0100, Tvrtko Ursulin w

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-17 Thread Danilo Krummrich
On Thu, Apr 17, 2025 at 05:08:12PM +0100, Tvrtko Ursulin wrote: > To catch up on why if you could dig out the links to past discussions it > would be helpful. I can't look it up currently, sorry. That's why I said Philipp will loop you in once he's back. :) > I repeat how there is a lot of attrac

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 08:45, Philipp Stanner wrote: On Mon, 2025-04-07 at 17:22 +0200, Philipp Stanner wrote: drm_sched_fini() can leak jobs under certain circumstances. Warn if that happens. Signed-off-by: Philipp Stanner ---  drivers/gpu/drm/scheduler/sched_main.c | 4 I hear a lot of amaz

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 15:48, Danilo Krummrich wrote: On Thu, Apr 17, 2025 at 03:20:44PM +0100, Tvrtko Ursulin wrote: On 17/04/2025 13:11, Danilo Krummrich wrote: On Thu, Apr 17, 2025 at 12:27:29PM +0100, Tvrtko Ursulin wrote: On 17/04/2025 08:45, Philipp Stanner wrote: On Mon, 2025-04-07 at 17:22

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-17 Thread Danilo Krummrich
On Thu, Apr 17, 2025 at 03:20:44PM +0100, Tvrtko Ursulin wrote: > > On 17/04/2025 13:11, Danilo Krummrich wrote: > > On Thu, Apr 17, 2025 at 12:27:29PM +0100, Tvrtko Ursulin wrote: > > > > > > On 17/04/2025 08:45, Philipp Stanner wrote: > > > > On Mon, 2025-04-07 at 17:22 +0200, Philipp Stanner w

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-17 Thread Tvrtko Ursulin
On 17/04/2025 13:11, Danilo Krummrich wrote: On Thu, Apr 17, 2025 at 12:27:29PM +0100, Tvrtko Ursulin wrote: On 17/04/2025 08:45, Philipp Stanner wrote: On Mon, 2025-04-07 at 17:22 +0200, Philipp Stanner wrote: Problem exactly is that jobs can outlive the entities and the scheduler, while

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-17 Thread Danilo Krummrich
On Thu, Apr 17, 2025 at 12:27:29PM +0100, Tvrtko Ursulin wrote: > > On 17/04/2025 08:45, Philipp Stanner wrote: > > On Mon, 2025-04-07 at 17:22 +0200, Philipp Stanner wrote: > > Problem exactly is that jobs can outlive the entities and the scheduler, > while some userspace may have a dma fence re

Re: [PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-04-17 Thread Philipp Stanner
On Mon, 2025-04-07 at 17:22 +0200, Philipp Stanner wrote: > drm_sched_fini() can leak jobs under certain circumstances. > > Warn if that happens. > > Signed-off-by: Philipp Stanner > --- >  drivers/gpu/drm/scheduler/sched_main.c | 4 I hear a lot of amazed silence for this series ^_^ If th