Re: [PATCH 26/49] drm/ttm: add wrapper to get manager from bdev.

2020-07-31 Thread Dave Airlie
On Fri, 31 Jul 2020 at 23:23, Christian König wrote: > > Am 31.07.20 um 06:04 schrieb Dave Airlie: > > From: Dave Airlie > > > > This will allow different abstractions later. > > Mhm, I'm questioning if this is really worth it and not just overkill. > > Running "sed -i 's/&bdev->man/bdev->man/'"

Re: [PATCH 26/49] drm/ttm: add wrapper to get manager from bdev.

2020-07-31 Thread Christian König
Am 31.07.20 um 06:04 schrieb Dave Airlie: From: Dave Airlie This will allow different abstractions later. Mhm, I'm questioning if this is really worth it and not just overkill. Running "sed -i 's/&bdev->man/bdev->man/'" on all drivers when we make the switch to a pointer should do it as wel

Re: [PATCH 26/49] drm/ttm: add wrapper to get manager from bdev.

2020-07-31 Thread daniel
On Fri, Jul 31, 2020 at 05:21:38PM +1000, Dave Airlie wrote: > On Fri, 31 Jul 2020 at 17:14, Thomas Zimmermann wrote: > > > > Hi > > > > Am 31.07.20 um 06:04 schrieb Dave Airlie: > > > From: Dave Airlie > > > > > > This will allow different abstractions later. > > > > You should consider moving t

Re: [PATCH 26/49] drm/ttm: add wrapper to get manager from bdev.

2020-07-31 Thread Dave Airlie
On Fri, 31 Jul 2020 at 17:14, Thomas Zimmermann wrote: > > Hi > > Am 31.07.20 um 06:04 schrieb Dave Airlie: > > From: Dave Airlie > > > > This will allow different abstractions later. > > You should consider moving this patch to the beginning of the series, so > that patches 1 to 25 can benefit f

Re: [PATCH 26/49] drm/ttm: add wrapper to get manager from bdev.

2020-07-31 Thread Thomas Zimmermann
Hi Am 31.07.20 um 06:04 schrieb Dave Airlie: > From: Dave Airlie > > This will allow different abstractions later. You should consider moving this patch to the beginning of the series, so that patches 1 to 25 can benefit from it. Best regards Thomas > > Signed-off-by: Dave Airlie > --- > d