Re: [PATCH 20/46] drm/i915/guc: Add hang check to GuC submit engine

2021-08-10 Thread Daniel Vetter
On Mon, Aug 09, 2021 at 07:05:58PM +, Matthew Brost wrote: > On Mon, Aug 09, 2021 at 05:35:25PM +0200, Daniel Vetter wrote: > > On Tue, Aug 03, 2021 at 03:29:17PM -0700, Matthew Brost wrote: > > > The heartbeat uses a single instance of a GuC submit engine (GSE) to do > > > the hang check. As s

Re: [PATCH 20/46] drm/i915/guc: Add hang check to GuC submit engine

2021-08-09 Thread Matthew Brost
On Mon, Aug 09, 2021 at 05:35:25PM +0200, Daniel Vetter wrote: > On Tue, Aug 03, 2021 at 03:29:17PM -0700, Matthew Brost wrote: > > The heartbeat uses a single instance of a GuC submit engine (GSE) to do > > the hang check. As such if a different GSE's state machine hangs, the > > heartbeat cannot

Re: [PATCH 20/46] drm/i915/guc: Add hang check to GuC submit engine

2021-08-09 Thread Daniel Vetter
On Tue, Aug 03, 2021 at 03:29:17PM -0700, Matthew Brost wrote: > The heartbeat uses a single instance of a GuC submit engine (GSE) to do > the hang check. As such if a different GSE's state machine hangs, the > heartbeat cannot detect this hang. Add timer to each GSE which in turn > can disable all