Re: [PATCH 2/6] drm/bridge: aux-hpd: separate allocation and registration

2024-02-23 Thread Johan Hovold
On Thu, Feb 22, 2024 at 10:57:07PM +0200, Dmitry Baryshkov wrote: > On Sat, 17 Feb 2024 at 17:03, Johan Hovold wrote: > > > > Combining allocation and registration is an anti-pattern that should be > > avoided. Add two new functions for allocating and registering an dp-hpd > > bridge with a proper

Re: [PATCH 2/6] drm/bridge: aux-hpd: separate allocation and registration

2024-02-22 Thread Dmitry Baryshkov
On Sat, 17 Feb 2024 at 17:03, Johan Hovold wrote: > > Combining allocation and registration is an anti-pattern that should be > avoided. Add two new functions for allocating and registering an dp-hpd > bridge with a proper 'devm' prefix so that it is clear that these are > device managed interface

Re: [PATCH 2/6] drm/bridge: aux-hpd: separate allocation and registration

2024-02-22 Thread Johan Hovold
On Wed, Feb 21, 2024 at 08:06:41PM -0600, Bjorn Andersson wrote: > On Sat, Feb 17, 2024 at 04:02:24PM +0100, Johan Hovold wrote: > > diff --git a/drivers/gpu/drm/bridge/aux-hpd-bridge.c > > b/drivers/gpu/drm/bridge/aux-hpd-bridge.c > [..] > > +/** > > + * devm_drm_dp_hpd_bridge_add - register a HD

Re: [PATCH 2/6] drm/bridge: aux-hpd: separate allocation and registration

2024-02-21 Thread Bjorn Andersson
On Sat, Feb 17, 2024 at 04:02:24PM +0100, Johan Hovold wrote: > diff --git a/drivers/gpu/drm/bridge/aux-hpd-bridge.c > b/drivers/gpu/drm/bridge/aux-hpd-bridge.c [..] > +/** > + * devm_drm_dp_hpd_bridge_add - register a HDP DisplayPort bridge kernel-doc wants () after function names. > + * @dev: