Re: [PATCH 2/4] sync_file: add replace and export some functionality

2017-03-15 Thread Dave Airlie
On 15 March 2017 at 18:55, Daniel Vetter wrote: > On Wed, Mar 15, 2017 at 02:19:16PM +1000, Dave Airlie wrote: >> > >> > uabi semantics question: Should we wake up everyone when the fence gets >> > replaced? What's the khr semaphore expectation here? >> >> There are no real semantics for this case

Re: [PATCH 2/4] sync_file: add replace and export some functionality

2017-03-15 Thread Daniel Vetter
On Wed, Mar 15, 2017 at 02:19:16PM +1000, Dave Airlie wrote: > > > > uabi semantics question: Should we wake up everyone when the fence gets > > replaced? What's the khr semaphore expectation here? > > There are no real semantics for this case, you either wait the semaphore and > replace it with N

Re: [PATCH 2/4] sync_file: add replace and export some functionality

2017-03-14 Thread Dave Airlie
> > uabi semantics question: Should we wake up everyone when the fence gets > replaced? What's the khr semaphore expectation here? There are no real semantics for this case, you either wait the semaphore and replace it with NULL, or signal it where you replace the fence with a new fence. Nobody s

Re: [PATCH 2/4] sync_file: add replace and export some functionality

2017-03-14 Thread Chris Wilson
On Tue, Mar 14, 2017 at 10:50:52AM +1000, Dave Airlie wrote: > From: Dave Airlie > > Using sync_file to back vulkan semaphores means need to replace > the fence underlying the sync file. This replace function removes > the callback, swaps the fence, and returns the old one. This > also exports th

Re: [PATCH 2/4] sync_file: add replace and export some functionality

2017-03-14 Thread Daniel Vetter
On Tue, Mar 14, 2017 at 10:50:52AM +1000, Dave Airlie wrote: > From: Dave Airlie > > Using sync_file to back vulkan semaphores means need to replace > the fence underlying the sync file. This replace function removes > the callback, swaps the fence, and returns the old one. This > also exports th