Re: [PATCH 2/4] drm/msm: drop qcom,chipid

2017-02-01 Thread Rob Clark
On Wed, Feb 1, 2017 at 12:09 PM, Rob Herring wrote: > On Mon, Jan 30, 2017 at 11:49:19AM -0500, Rob Clark wrote: >> The original way we determined the gpu version was based on downstream >> bindings from android kernel. A cleaner way is to get the version from >> the compatible string. >> >> Note

Re: [PATCH 2/4] drm/msm: drop qcom,chipid

2017-02-01 Thread Rob Herring
On Mon, Jan 30, 2017 at 11:49:19AM -0500, Rob Clark wrote: > The original way we determined the gpu version was based on downstream > bindings from android kernel. A cleaner way is to get the version from > the compatible string. > > Note that no upstream dtb uses these bindings. But the code st

Re: [PATCH 2/4] drm/msm: drop qcom,chipid

2017-01-30 Thread Rob Clark
On Mon, Jan 30, 2017 at 2:54 PM, Eric Anholt wrote: > Rob Clark writes: > >> On Mon, Jan 30, 2017 at 1:09 PM, Eric Anholt wrote: >>> Rob Clark writes: >>> The original way we determined the gpu version was based on downstream bindings from android kernel. A cleaner way is to get the

Re: [PATCH 2/4] drm/msm: drop qcom,chipid

2017-01-30 Thread Eric Anholt
Rob Clark writes: > On Mon, Jan 30, 2017 at 1:09 PM, Eric Anholt wrote: >> Rob Clark writes: >> >>> The original way we determined the gpu version was based on downstream >>> bindings from android kernel. A cleaner way is to get the version from >>> the compatible string. >>> >>> Note that no

Re: [PATCH 2/4] drm/msm: drop qcom,chipid

2017-01-30 Thread Rob Clark
On Mon, Jan 30, 2017 at 1:09 PM, Eric Anholt wrote: > Rob Clark writes: > >> The original way we determined the gpu version was based on downstream >> bindings from android kernel. A cleaner way is to get the version from >> the compatible string. >> >> Note that no upstream dtb uses these bindi

Re: [PATCH 2/4] drm/msm: drop qcom,chipid

2017-01-30 Thread Eric Anholt
Rob Clark writes: > The original way we determined the gpu version was based on downstream > bindings from android kernel. A cleaner way is to get the version from > the compatible string. > > Note that no upstream dtb uses these bindings. But the code still > supports falling back to the legac