Re: [PATCH 2/4] drm/i2c: nxp-tda998x (v2)

2013-01-24 Thread Rob Clark
On Thu, Jan 24, 2013 at 5:57 AM, Daniel Vetter wrote: > On Tue, Jan 22, 2013 at 04:36:23PM -0600, Rob Clark wrote: >> Driver for the NXP TDA998X i2c hdmi encoder slave. >> >> v1: original >> v2: fix npix/nline programming >> >> Signed-off-by: Rob Clark > > Just one bikeshed, otherwise > > Reviewe

Re: [PATCH 2/4] drm/i2c: nxp-tda998x (v2)

2013-01-24 Thread Daniel Vetter
On Tue, Jan 22, 2013 at 04:36:23PM -0600, Rob Clark wrote: > Driver for the NXP TDA998X i2c hdmi encoder slave. > > v1: original > v2: fix npix/nline programming > > Signed-off-by: Rob Clark Just one bikeshed, otherwise Reviewed-by: Daniel Vetter [cut] > +static void > +reg_set(struct drm_e

Re: [PATCH 2/4] drm/i2c: nxp-tda998x (v2)

2013-01-23 Thread Jean-Francois Moine
On Tue, 22 Jan 2013 16:36:23 -0600 Rob Clark wrote: > Driver for the NXP TDA998X i2c hdmi encoder slave. > > v1: original > v2: fix npix/nline programming > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/i2c/Makefile | 3 + > drivers/gpu/drm/i2c/tda998x_drv.c | 908 > +

Re: [PATCH 2/4] drm/i2c: nxp-tda998x (v2)

2013-01-23 Thread Koen Kooi
Op 22 jan. 2013, om 23:36 heeft Rob Clark het volgende geschreven: > Driver for the NXP TDA998X i2c hdmi encoder slave. > > v1: original > v2: fix npix/nline programming > > Signed-off-by: Rob Clark Tested on a beaglebone-black: Tested-by: Koen Kooi _

Re: [PATCH 2/4] drm/i2c: nxp-tda998x (v2)

2013-01-23 Thread Rob Clark
On Wed, Jan 23, 2013 at 3:42 AM, Jean-Francois Moine wrote: > On Tue, 22 Jan 2013 16:36:23 -0600 > Rob Clark wrote: > >> Driver for the NXP TDA998X i2c hdmi encoder slave. >> >> v1: original >> v2: fix npix/nline programming >> >> Signed-off-by: Rob Clark >> --- >> drivers/gpu/drm/i2c/Makefile