Re: [PATCH 2/3] drm: make DRM_UNLOCKED ioctls with their own mutex

2011-10-26 Thread Daniel Vetter
On Wed, Oct 26, 2011 at 11:11:14AM -0500, Ilija Hadzic wrote: > On Wed, 26 Oct 2011, Daniel Vetter wrote: > > > >Just to check before I dig into reviewing this: Have you check all the > >other users of these data structure that these functions touch whether > >they don't accidentally rely on the gl

Re: [PATCH 2/3] drm: make DRM_UNLOCKED ioctls with their own mutex

2011-10-26 Thread Ilija Hadzic
On Wed, 26 Oct 2011, Daniel Vetter wrote: Just to check before I dig into reviewing this: Have you check all the other users of these data structure that these functions touch whether they don't accidentally rely on the global lock being taken? I did and thought it was safe. I re-checked th

Re: [PATCH 2/3] drm: make DRM_UNLOCKED ioctls with their own mutex

2011-10-26 Thread Daniel Vetter
On Tue, Oct 25, 2011 at 10:20:13PM -0400, Ilija Hadzic wrote: > drm_getmap, drm_getclient and drm_getstats are all > protected with their own mutex (dev->struct_mutex) > no need to hold global mutex; make them DRM_UNLOCKED > > Signed-off-by: Ilija Hadzic Just to check before I dig into reviewing