Re: [PATCH 2/3] drm: Create a format/modifier blob

2017-05-11 Thread Ben Widawsky
On 17-05-03 14:15:15, Liviu Dudau wrote: On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: Updated blob layout (Rob, Daniel, Kristian, xerpi) Cc: Rob Clark Cc: Daniel Stone Cc: Kristian H. Kristensen Signed-off-by: Ben Widawsky --- drivers/gpu/drm/drm_mode_config.c | 7 +++ d

Re: [PATCH 2/3] drm: Create a format/modifier blob

2017-05-04 Thread Daniel Stone
Hi, On 3 May 2017 at 06:14, Ben Widawsky wrote: > Updated blob layout (Rob, Daniel, Kristian, xerpi) In terms of the blob as uABI, we've got an implementation inside Weston which works: https://git.collabora.com/cgit/user/daniels/weston.git/commit/?h=wip/2017-04/atomic-v11-WIP&id=0a47cb63947e T

Re: [PATCH 2/3] drm: Create a format/modifier blob

2017-05-03 Thread Emil Velikov
Hi Ben, On 3 May 2017 at 06:14, Ben Widawsky wrote: > +struct drm_format_modifier_blob { > +#define FORMAT_BLOB_CURRENT 1 > + /* Version of this blob format */ > + u32 version; > + > + /* Flags */ > + u32 flags; > + > + /* Number of fourcc formats supported */ > +

Re: [PATCH 2/3] drm: Create a format/modifier blob

2017-05-03 Thread Liviu Dudau
On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: > Updated blob layout (Rob, Daniel, Kristian, xerpi) > > Cc: Rob Clark > Cc: Daniel Stone > Cc: Kristian H. Kristensen > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/drm_mode_config.c | 7 +++ > drivers/gpu/drm/drm_plane.c

Re: [PATCH 2/3] drm: Create a format/modifier blob

2017-05-03 Thread Brian Starkey
Hi, On Tue, May 02, 2017 at 10:14:27PM -0700, Ben Widawsky wrote: Updated blob layout (Rob, Daniel, Kristian, xerpi) Cc: Rob Clark Cc: Daniel Stone Cc: Kristian H. Kristensen Signed-off-by: Ben Widawsky --- drivers/gpu/drm/drm_mode_config.c | 7 +++ drivers/gpu/drm/drm_plane.c | 119

Re: [PATCH 2/3] drm: Create a format/modifier blob

2017-05-03 Thread Brian Starkey
Hi Daniel, On Wed, May 03, 2017 at 12:47:18PM +0100, Daniel Stone wrote: Hi Brian, On 3 May 2017 at 12:00, Brian Starkey wrote: Having just caught up on IRC I'm sure I'm far too late for this party, but... Wouldn't this whole thing be a whole lot simpler if "IN_FORMATS" stored "pointers" to

Re: [PATCH 2/3] drm: Create a format/modifier blob

2017-05-03 Thread Daniel Stone
Hi Brian, On 3 May 2017 at 12:00, Brian Starkey wrote: > Having just caught up on IRC I'm sure I'm far too late for this party, > but... > > Wouldn't this whole thing be a whole lot simpler if "IN_FORMATS" > stored "pointers" to separate blobs for the format and modifier lists? > > I've used/writ

Re: [PATCH 2/3] drm: Create a format/modifier blob

2017-05-03 Thread Brian Starkey
Hi, Having just caught up on IRC I'm sure I'm far too late for this party, but... Wouldn't this whole thing be a whole lot simpler if "IN_FORMATS" stored "pointers" to separate blobs for the format and modifier lists? struct drm_format_modifier_blob { #define FORMAT_BLOB_CURRENT 1 /* Ve