Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-22 Thread Dmitry Baryshkov
On 23/06/2023 01:37, Abhinav Kumar wrote: On 6/21/2023 4:46 PM, Dmitry Baryshkov wrote: On 22/06/2023 02:01, Abhinav Kumar wrote: On 6/21/2023 9:36 AM, Dmitry Baryshkov wrote: On 21/06/2023 18:17, Marijn Suijten wrote: On 2023-06-20 14:38:34, Jessica Zhang wrote: +    if (phys_enc->hw_i

Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-22 Thread Abhinav Kumar
On 6/21/2023 4:46 PM, Dmitry Baryshkov wrote: On 22/06/2023 02:01, Abhinav Kumar wrote: On 6/21/2023 9:36 AM, Dmitry Baryshkov wrote: On 21/06/2023 18:17, Marijn Suijten wrote: On 2023-06-20 14:38:34, Jessica Zhang wrote: +    if (phys_enc->hw_intf->ops.enable_widebus) + phys_en

Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-21 Thread Dmitry Baryshkov
On 22/06/2023 02:01, Abhinav Kumar wrote: On 6/21/2023 9:36 AM, Dmitry Baryshkov wrote: On 21/06/2023 18:17, Marijn Suijten wrote: On 2023-06-20 14:38:34, Jessica Zhang wrote: +    if (phys_enc->hw_intf->ops.enable_widebus) +    phys_enc->hw_intf->ops.enable_widebus(phys_enc->hw_intf);

Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-21 Thread Abhinav Kumar
On 6/21/2023 9:36 AM, Dmitry Baryshkov wrote: On 21/06/2023 18:17, Marijn Suijten wrote: On 2023-06-20 14:38:34, Jessica Zhang wrote: +    if (phys_enc->hw_intf->ops.enable_widebus) +    phys_enc->hw_intf->ops.enable_widebus(phys_enc->hw_intf); No. Please provide a single function whi

Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-21 Thread Marijn Suijten
On 2023-06-21 19:36:37, Dmitry Baryshkov wrote: > On 21/06/2023 18:17, Marijn Suijten wrote: > > On 2023-06-20 14:38:34, Jessica Zhang wrote: > > > >>> +    if (phys_enc->hw_intf->ops.enable_widebus) > >>> +    phys_enc->hw_intf->ops.enable_widebus(phys_enc->hw_intf); > >> > >>

Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-21 Thread Dmitry Baryshkov
On 21/06/2023 18:17, Marijn Suijten wrote: On 2023-06-20 14:38:34, Jessica Zhang wrote: +    if (phys_enc->hw_intf->ops.enable_widebus) +    phys_enc->hw_intf->ops.enable_widebus(phys_enc->hw_intf); No. Please provide a single function which takes necessary configuration, including compre

Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-21 Thread Marijn Suijten
On 2023-06-20 14:38:34, Jessica Zhang wrote: > > +    if (phys_enc->hw_intf->ops.enable_widebus) > > +    phys_enc->hw_intf->ops.enable_widebus(phys_enc->hw_intf); > > No. Please provide a single function which takes necessary > configuration, including compression and w

Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-20 Thread Dmitry Baryshkov
On Wed, 21 Jun 2023 at 00:38, Jessica Zhang wrote: > > > > On 6/16/2023 5:35 PM, Dmitry Baryshkov wrote: > > On 17/06/2023 00:54, Marijn Suijten wrote: > >> On 2023-06-16 14:18:39, Abhinav Kumar wrote: > >>> > >>> > >>> On 6/14/2023 12:56 AM, Dmitry Baryshkov wrote: > On 14/06/2023 04:57, Jes

Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-20 Thread Jessica Zhang
On 6/16/2023 5:35 PM, Dmitry Baryshkov wrote: On 17/06/2023 00:54, Marijn Suijten wrote: On 2023-06-16 14:18:39, Abhinav Kumar wrote: On 6/14/2023 12:56 AM, Dmitry Baryshkov wrote: On 14/06/2023 04:57, Jessica Zhang wrote: Add a DPU INTF op to set the DATABUS_WIDEN register to enable the

Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-16 Thread Dmitry Baryshkov
On 17/06/2023 00:54, Marijn Suijten wrote: On 2023-06-16 14:18:39, Abhinav Kumar wrote: On 6/14/2023 12:56 AM, Dmitry Baryshkov wrote: On 14/06/2023 04:57, Jessica Zhang wrote: Add a DPU INTF op to set the DATABUS_WIDEN register to enable the databus-widen mode datapath. Signed-off-by: Jess

Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-16 Thread Marijn Suijten
On 2023-06-16 14:18:39, Abhinav Kumar wrote: > > > On 6/14/2023 12:56 AM, Dmitry Baryshkov wrote: > > On 14/06/2023 04:57, Jessica Zhang wrote: > >> Add a DPU INTF op to set the DATABUS_WIDEN register to enable the > >> databus-widen mode datapath. > >> > >> Signed-off-by: Jessica Zhang > >> ---

Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-16 Thread Abhinav Kumar
On 6/14/2023 12:56 AM, Dmitry Baryshkov wrote: On 14/06/2023 04:57, Jessica Zhang wrote: Add a DPU INTF op to set the DATABUS_WIDEN register to enable the databus-widen mode datapath. Signed-off-by: Jessica Zhang ---   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c |  3 +++   drivers/

Re: [PATCH 2/3] drm/msm/dpu: Set DATABUS_WIDEN on command mode encoders

2023-06-14 Thread Dmitry Baryshkov
On 14/06/2023 04:57, Jessica Zhang wrote: Add a DPU INTF op to set the DATABUS_WIDEN register to enable the databus-widen mode datapath. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 3 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 12 +