Re: [PATCH 2/2] drm/sched: fix timeout handling v2

2018-10-09 Thread Nayan Deshmukh
On Tue, Oct 9, 2018 at 8:20 PM Christian König wrote: > > We need to make sure that we don't race between job completion and > timeout. > > v2: put revert label after calling the handling manually > > Signed-off-by: Christian König Reviewed-by: Nayan Deshmukh > --- > drivers/gpu/drm/scheduler/s

Re: [PATCH 2/2] drm/sched: fix timeout handling

2018-10-08 Thread Koenig, Christian
Am 08.10.2018 um 20:01 schrieb Nayan Deshmukh: > Thanks for all the explanations. Looks like this part of scheduler has > a lot of bugs. > > On Tue, Oct 9, 2018 at 2:55 AM Christian König > wrote: >> Am 08.10.2018 um 19:40 schrieb Nayan Deshmukh: >>> Hi Christian, >>> >>> I am a bit confused with

Re: [PATCH 2/2] drm/sched: fix timeout handling

2018-10-08 Thread Nayan Deshmukh
Thanks for all the explanations. Looks like this part of scheduler has a lot of bugs. On Tue, Oct 9, 2018 at 2:55 AM Christian König wrote: > > Am 08.10.2018 um 19:40 schrieb Nayan Deshmukh: > > Hi Christian, > > > > I am a bit confused with this patch. It will be better if you can > > explain wh

Re: [PATCH 2/2] drm/sched: fix timeout handling

2018-10-08 Thread Christian König
Am 08.10.2018 um 19:40 schrieb Nayan Deshmukh: Hi Christian, I am a bit confused with this patch. It will be better if you can explain what these 3 functions are supposed to do. From my understanding this is what they are supposed to do: 1. drm_sched_job_timedout: This function is called when a

Re: [PATCH 2/2] drm/sched: fix timeout handling

2018-10-08 Thread Nayan Deshmukh
Hi Christian, I am a bit confused with this patch. It will be better if you can explain what these 3 functions are supposed to do. From my understanding this is what they are supposed to do: 1. drm_sched_job_timedout: This function is called when a job has been executing for more than "timeout" s