Hi Sam,
Thank you for your suggestions.
See my reply inline.
On Vi, 2019-06-14 at 17:10 +0200, Sam Ravnborg wrote:
> Hi Robert.
>
> On top of the feedback from Fabio here is a bit more.
>
> >
> > +
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#
On Vi, 2019-06-14 at 10:39 -0300, Fabio Estevam wrote:
> Caution: EXT Email
>
> On Fri, Jun 14, 2019 at 10:29 AM Robert Chiras > wrote:
>
> >
> > The GPIO is active high, and the above sequence was received from
> > the
> > panel vendor in the following form:
> > SET_RESET_PIN(1);
> >
Hi Robert.
On top of the feedback from Fabio here is a bit more.
> +
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
Divide include up in block in following order:
#include
#include
#incude
With
On Fri, Jun 14, 2019 at 10:29 AM Robert Chiras wrote:
> The GPIO is active high, and the above sequence was received from the
> panel vendor in the following form:
> SET_RESET_PIN(1);
> MDELAY(10);
> SET_RESET_PIN(0);
> MDELAY(5);
> SET_RESET_PIN(1);
>
Hi Fabio,
On Vi, 2019-06-14 at 09:27 -0300, Fabio Estevam wrote:
> Hi Robert,
>
> On Fri, Jun 14, 2019 at 8:52 AM Robert Chiras
> wrote:
>
> >
> > --- /dev/null
> > +++ b/drivers/gpu/drm/panel/panel-raydium-rm67191.c
> > @@ -0,0 +1,730 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > +
Hi Robert,
On Fri, Jun 14, 2019 at 8:52 AM Robert Chiras wrote:
> --- /dev/null
> +++ b/drivers/gpu/drm/panel/panel-raydium-rm67191.c
> @@ -0,0 +1,730 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * i.MX drm driver - Raydium MIPI-DSI panel driver
> + *
> + * Copyright (C) 2017 NXP
> + *
>
Hi Robert,
Minor comment. See inline:
On Fri, Jun 14, 2019 at 2:52 PM Robert Chiras wrote:
>
> This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI
> protocol).
>
> Signed-off-by: Robert Chiras
> ---
> drivers/gpu/drm/panel/Kconfig | 9 +
> drivers/gpu/drm/panel/Mak
