Re: [PATCH 2/2] drm/panel: Add driver for Samsung S6E63M0 panel

2019-01-29 Thread Paweł Chmiel
On poniedziałek, 28 stycznia 2019 14:47:41 CET Andrzej Hajda wrote: > Hi Paweł, > > Nice work. > > I agree with most Sam's comments (maybe expect DRM_DEV_* logging - I am > not sure if we need concurrent logging facility). > > I'd like to add few more comments: > > > > On 25.01.2019 17:46, Pa

Re: [PATCH 2/2] drm/panel: Add driver for Samsung S6E63M0 panel

2019-01-28 Thread Andrzej Hajda
Hi Paweł, Nice work. I agree with most Sam's comments (maybe expect DRM_DEV_* logging - I am not sure if we need concurrent logging facility). I'd like to add few more comments: On 25.01.2019 17:46, Paweł Chmiel wrote: > This patch adds Samsung S6E63M0 AMOLED LCD panel driver, connected over

Re: [PATCH 2/2] drm/panel: Add driver for Samsung S6E63M0 panel

2019-01-26 Thread Sam Ravnborg
Hi Pawel. Thanks for this nice patch too. Comment follows and you need to judge what to follow. The timing part will not be commented as this was covered in feedback on the binding. Using a sysfs file to select the gamma mode looks like a local hack. Someone with more drm knowledge needs comment