Re: [PATCH 2/2] drm/panel: Add Samsung S6E3FA2 DSI panel driver

2021-07-26 Thread Linus Walleij
Hi Alexey, I had some gmail problems and replied to the very old driver by Iskren, sorry for the mess. I overall like this driver a lot. Some of Sam's comments could be addressed especially for backlight. I think the driver should indeed handle both the physical displays like you do here. On Su

Re: [PATCH 2/2] drm/panel: Add Samsung S6E3FA2 DSI panel driver

2021-07-26 Thread Linus Walleij
On Sun, Jul 25, 2021 at 5:01 PM Sam Ravnborg wrote: > This driver supports two different panels: > > S6E3FA2 > EA8064G > > They differ on a lot of the tables and requires different init. > In other words there is only a little boiler plate code that is in > common. > > I think it

Re: [PATCH 2/2] drm/panel: Add Samsung S6E3FA2 DSI panel driver

2021-07-25 Thread Sam Ravnborg
Hi Alexey, On Sun, Jul 25, 2021 at 05:03:38PM +0300, Alexey Minnekhanov wrote: > Samsung S6E3FA2 panel is amoled 1080x1920 command mode DSI > panel used in Samsung Galaxy S5 phone. There are 2 known > variations of panel that were shipped in this phone, and > this driver handles both of them. > >