Re: [PATCH 2/2] drm/nouveau: Remove nvkm_gsp_fwif.enable

2025-07-14 Thread Ben Skeggs
On 7/15/25 02:04, M Henning wrote: On Sun, Jul 13, 2025 at 11:19 PM Ben Skeggs wrote: Yeah, the GPUs that don't support GSP-RM can't hit the code that used fwif.enable anyway, so the series should be fine as it is. We're actually talking about the reverse case. That is, on Ada what happens if

Re: [PATCH 2/2] drm/nouveau: Remove nvkm_gsp_fwif.enable

2025-07-14 Thread M Henning
On Sun, Jul 13, 2025 at 11:19 PM Ben Skeggs wrote: > Yeah, the GPUs that don't support GSP-RM can't hit the code that used > fwif.enable anyway, so the series should be fine as it is. We're actually talking about the reverse case. That is, on Ada what happens if you set nouveau.config=NvGspRm=0 o

Re: [PATCH 2/2] drm/nouveau: Remove nvkm_gsp_fwif.enable

2025-07-13 Thread Ben Skeggs
On 6/27/25 03:15, M Henning wrote: On Tue, Jun 24, 2025 at 3:13 PM Timur Tabi wrote: You have a good point, but I think your change, in effect, necessitates my request. Previously, the default was no GSP-RM unless needed. Now it's yes GSP-RM, and the concept of "need" has been removed. So

Re: [PATCH 2/2] drm/nouveau: Remove nvkm_gsp_fwif.enable

2025-06-26 Thread M Henning
On Tue, Jun 24, 2025 at 3:13 PM Timur Tabi wrote: > You have a good point, but I think your change, in effect, necessitates my > request. Previously, the > default was no GSP-RM unless needed. Now it's yes GSP-RM, and the concept of > "need" has been > removed. So there's no indication any mo

Re: [PATCH 2/2] drm/nouveau: Remove nvkm_gsp_fwif.enable

2025-06-24 Thread Timur Tabi
On Tue, 2025-06-24 at 15:01 -0400, M Henning wrote: > We did no such error checking before this series (in fact, most of > these options have almost no error checking). Are you saying you want > to see this added in this patch series? You have a good point, but I think your change, in effect, nece

Re: [PATCH 2/2] drm/nouveau: Remove nvkm_gsp_fwif.enable

2025-06-24 Thread M Henning
On Tue, Jun 24, 2025 at 1:28 PM Timur Tabi wrote: > Instead of removing it, I think we should rename it to indicate whether > GSP-RM is required. You > cannot boot Ada or later without GSP-RM, so on those platforms, > nouveau.config=NvGspRm=0 should be > ignored, and a pr_warn should be issued

Re: [PATCH 2/2] drm/nouveau: Remove nvkm_gsp_fwif.enable

2025-06-24 Thread Timur Tabi
On Mon, 2025-06-23 at 18:04 -0400, Mel Henning wrote: > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/priv.h > b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/priv.h > index 4f14e85fc69e..c3494b7ac572 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/priv.h > +++ b/drivers/gpu/drm/nouveau/nvk