Re: [PATCH 2/2] drm/i915: properly clflush pwrites to phys objects

2011-11-29 Thread Daniel Vetter
On Tue, Nov 29, 2011 at 05:16:52PM +0100, Daniel Vetter wrote: > On Tue, Nov 29, 2011 at 03:35:54PM +, Chris Wilson wrote: > > On Tue, 29 Nov 2011 16:09:29 +0100, Daniel Vetter > > wrote: > > > Usually results in (rare) cursor corruptions on platforms > > > requiring physically addressed curs

Re: [PATCH 2/2] drm/i915: properly clflush pwrites to phys objects

2011-11-29 Thread Daniel Vetter
On Tue, Nov 29, 2011 at 03:35:54PM +, Chris Wilson wrote: > On Tue, 29 Nov 2011 16:09:29 +0100, Daniel Vetter > wrote: > > Usually results in (rare) cursor corruptions on platforms > > requiring physically addressed cursors. > > So the phys cursor pages are set to WC upon creation, are we ju

Re: [PATCH 2/2] drm/i915: properly clflush pwrites to phys objects

2011-11-29 Thread Chris Wilson
On Tue, 29 Nov 2011 16:09:29 +0100, Daniel Vetter wrote: > Usually results in (rare) cursor corruptions on platforms > requiring physically addressed cursors. So the phys cursor pages are set to WC upon creation, are we just missing the mb()? Or more likely the CPUs don't have PAT and we are bei