Re: [PATCH 2/2] drm/i915/gem: Fix Virtual Memory mapping boundaries calculation

2024-08-05 Thread Andi Shyti
Hi Jonathan, ... > > + set_address_limits(area, vma, obj_offset, &start, &end); > > + > > + pfn = (ggtt->gmadr.start + i915_ggtt_offset(vma)) >> PAGE_SHIFT; > > + pfn += (start - area->vm_start) >> PAGE_SHIFT; > > + pfn += obj_offset - vma->gtt_view.partial.offset; > > I don't know how v

RE: [PATCH 2/2] drm/i915/gem: Fix Virtual Memory mapping boundaries calculation

2024-08-02 Thread Cavitt, Jonathan
-Original Message- From: Intel-gfx On Behalf Of Andi Shyti Sent: Friday, August 2, 2024 1:39 AM To: intel-gfx ; dri-devel Cc: Jann Horn ; Jani Nikula ; Joonas Lahtinen ; Vivi, Rodrigo ; Tvrtko Ursulin ; Jann Horn ; Chris Wilson ; Niemiec, Krzysztof ; Andi Shyti ; Auld, Matthew ; An

Re: [PATCH 2/2] drm/i915/gem: Fix Virtual Memory mapping boundaries calculation

2024-08-02 Thread Jann Horn
On Fri, Aug 2, 2024 at 10:39 AM Andi Shyti wrote: > Calculating the size of the mapped area as the lesser value > between the requested size and the actual size does not consider > the partial mapping offset. This can cause page fault access. > > Fix the calculation of the starting and ending addr