Re: [PATCH 13/27] drm/i915/guc: Take context ref when cancelling request

2021-08-24 Thread Daniele Ceraolo Spurio
On 8/24/2021 8:42 AM, Matthew Brost wrote: On Fri, Aug 20, 2021 at 05:07:27PM -0700, Daniele Ceraolo Spurio wrote: On 8/18/2021 11:16 PM, Matthew Brost wrote: A context can get destroyed after cancelling a request so take a reference to context when cancelling a request. What's the exact r

Re: [PATCH 13/27] drm/i915/guc: Take context ref when cancelling request

2021-08-24 Thread Matthew Brost
On Fri, Aug 20, 2021 at 05:07:27PM -0700, Daniele Ceraolo Spurio wrote: > > > On 8/18/2021 11:16 PM, Matthew Brost wrote: > > A context can get destroyed after cancelling a request so take a > > reference to context when cancelling a request. > > What's the exact race? AFAICS __i915_request_skip

Re: [PATCH 13/27] drm/i915/guc: Take context ref when cancelling request

2021-08-20 Thread Daniele Ceraolo Spurio
On 8/18/2021 11:16 PM, Matthew Brost wrote: A context can get destroyed after cancelling a request so take a reference to context when cancelling a request. What's the exact race? AFAICS __i915_request_skip does not have a context_put(). Daniele Fixes: 62eaf0ae217d ("drm/i915/guc: Supp