Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-24 Thread Joel Fernandes
On 4/23/2025 10:06 AM, Danilo Krummrich wrote: > On Sun, Apr 20, 2025 at 09:19:45PM +0900, Alexandre Courbot wrote: >> From: Joel Fernandes >> >> Add support for navigating and setting up vBIOS ucode data required for >> GSP to boot. The main data extracted from the vBIOS is the FWSEC-FRTS >> f

Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-24 Thread Danilo Krummrich
On Thu, Apr 24, 2025 at 03:54:48PM -0400, Joel Fernandes wrote: > On Wed, Apr 23, 2025 at 05:02:58PM +0200, Danilo Krummrich wrote: > > On Wed, Apr 23, 2025 at 10:52:42AM -0400, Joel Fernandes wrote: > > > Hello, Danilo, > > > Thanks for all the feedback. Due to the volume of feedback, I will respo

Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-24 Thread Danilo Krummrich
On Thu, Apr 24, 2025 at 02:54:42PM -0400, Joel Fernandes wrote: > > > On 4/23/2025 10:06 AM, Danilo Krummrich wrote: > [...] > >> + > >> +/// Probe for VBIOS extraction > >> +/// Once the VBIOS object is built, bar0 is not read for vbios > >> purposes anymore. > >> +pub(crate) fn pro

Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-24 Thread Danilo Krummrich
On Thu, Apr 24, 2025 at 03:19:00PM -0400, Joel Fernandes wrote: > On Wed, Apr 23, 2025 at 05:02:58PM +0200, Danilo Krummrich wrote: > > [..] > > > > >> +data.extend_with(len, 0, GFP_KERNEL)?; > > > >> +with_bar!(?bar0, |bar0_ref| { > > > >> +let dst = &mut data[current

Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-24 Thread Joel Fernandes
On Wed, Apr 23, 2025 at 05:02:58PM +0200, Danilo Krummrich wrote: > On Wed, Apr 23, 2025 at 10:52:42AM -0400, Joel Fernandes wrote: > > Hello, Danilo, > > Thanks for all the feedback. Due to the volume of feedback, I will respond > > incrementally in multiple emails so we can discuss as we go - hop

Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-24 Thread Joel Fernandes
On Wed, Apr 23, 2025 at 05:02:58PM +0200, Danilo Krummrich wrote: [..] > > >> +data.extend_with(len, 0, GFP_KERNEL)?; > > >> +with_bar!(?bar0, |bar0_ref| { > > >> +let dst = &mut data[current_len..current_len + len]; > > >> +for (idx, chunk) in dst > > >> +

Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-24 Thread Joel Fernandes
On 4/23/2025 10:06 AM, Danilo Krummrich wrote: [...] >> + >> +/// Probe for VBIOS extraction >> +/// Once the VBIOS object is built, bar0 is not read for vbios purposes >> anymore. >> +pub(crate) fn probe(bar0: &Devres) -> Result { > > Let's not call it probe(), what about VBios::p

Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-23 Thread Danilo Krummrich
On Wed, Apr 23, 2025 at 10:52:42AM -0400, Joel Fernandes wrote: > Hello, Danilo, > Thanks for all the feedback. Due to the volume of feedback, I will respond > incrementally in multiple emails so we can discuss as we go - hope that's Ok > but > let me know if that is annoying. That's perfectly fi

Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-23 Thread Joel Fernandes
Hello, Danilo, Thanks for all the feedback. Due to the volume of feedback, I will respond incrementally in multiple emails so we can discuss as we go - hope that's Ok but let me know if that is annoying. On 4/23/2025 10:06 AM, Danilo Krummrich wrote: > On Sun, Apr 20, 2025 at 09:19:45PM +0900, Ale

Re: [PATCH 13/16] gpu: nova-core: Add support for VBIOS ucode extraction for boot

2025-04-23 Thread Danilo Krummrich
On Sun, Apr 20, 2025 at 09:19:45PM +0900, Alexandre Courbot wrote: > From: Joel Fernandes > > Add support for navigating and setting up vBIOS ucode data required for > GSP to boot. The main data extracted from the vBIOS is the FWSEC-FRTS > firmware which runs on the GSP processor. This firmware r