Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Daniel Vetter
On Tue, Dec 1, 2020 at 11:27 AM Thomas Zimmermann wrote: > > Hi > > Am 01.12.20 um 11:00 schrieb Daniel Vetter: > > On Tue, Dec 1, 2020 at 10:40 AM Thomas Zimmermann > > wrote: > >> > >> Hi > >> > >> Am 01.12.20 um 10:10 schrieb Daniel Vetter: > >>> On Tue, Dec 1, 2020 at 9:32 AM Thomas Zimmerma

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Christian König
Am 01.12.20 um 13:53 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 13:51 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 13:38 schrieb Christian König: Am 01.12.20 um 13:33 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 13:14 schrieb Christian König: Am 01.12.20 um 12:30 schrieb Thomas Zimmerman

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Thomas Zimmermann
Hi Am 01.12.20 um 13:51 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 13:38 schrieb Christian König: Am 01.12.20 um 13:33 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 13:14 schrieb Christian König: Am 01.12.20 um 12:30 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 11:34 schrieb Christian Kö

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Thomas Zimmermann
Hi Am 01.12.20 um 13:38 schrieb Christian König: Am 01.12.20 um 13:33 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 13:14 schrieb Christian König: Am 01.12.20 um 12:30 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 11:34 schrieb Christian König: [...] In patch 6 of this series, there's ast cu

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Christian König
Am 01.12.20 um 13:33 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 13:14 schrieb Christian König: Am 01.12.20 um 12:30 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 11:34 schrieb Christian König: [...] In patch 6 of this series, there's ast cursor code that acquires two BO's reservation locks

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Thomas Zimmermann
Hi Am 01.12.20 um 13:14 schrieb Christian König: Am 01.12.20 um 12:30 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 11:34 schrieb Christian König: [...] In patch 6 of this series, there's ast cursor code that acquires two BO's reservation locks and vmaps them afterwards. That's probably how

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Christian König
Am 01.12.20 um 12:30 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 11:34 schrieb Christian König: [...] In patch 6 of this series, there's ast cursor code that acquires two BO's reservation locks and vmaps them afterwards. That's probably how you intend to use dma_buf_vmap_local. However, I

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Thomas Zimmermann
Hi Am 01.12.20 um 11:00 schrieb Daniel Vetter: [...] For my POV, the current interfaces have no clear policy or semantics. Looking through the different GEM implementations, each one seems to have its own interpretation. Yup, that's the problem really. In the past we've had vmap exclusively fo

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Thomas Zimmermann
Hi Am 01.12.20 um 11:34 schrieb Christian König: [...] In patch 6 of this series, there's ast cursor code that acquires two BO's reservation locks and vmaps them afterwards. That's probably how you intend to use dma_buf_vmap_local. However, I think it's more logically to have a vmap callback

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Christian König
Am 01.12.20 um 11:27 schrieb Thomas Zimmermann: Hi Am 01.12.20 um 11:00 schrieb Daniel Vetter: On Tue, Dec 1, 2020 at 10:40 AM Thomas Zimmermann wrote: Hi Am 01.12.20 um 10:10 schrieb Daniel Vetter: On Tue, Dec 1, 2020 at 9:32 AM Thomas Zimmermann wrote: Hi Am 30.11.20 um 16:33 schrieb

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Thomas Zimmermann
Hi Am 01.12.20 um 11:00 schrieb Daniel Vetter: On Tue, Dec 1, 2020 at 10:40 AM Thomas Zimmermann wrote: Hi Am 01.12.20 um 10:10 schrieb Daniel Vetter: On Tue, Dec 1, 2020 at 9:32 AM Thomas Zimmermann wrote: Hi Am 30.11.20 um 16:33 schrieb Christian König: Am 30.11.20 um 16:30 schrieb D

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Daniel Vetter
On Tue, Dec 1, 2020 at 10:40 AM Thomas Zimmermann wrote: > > Hi > > Am 01.12.20 um 10:10 schrieb Daniel Vetter: > > On Tue, Dec 1, 2020 at 9:32 AM Thomas Zimmermann > > wrote: > >> > >> Hi > >> > >> Am 30.11.20 um 16:33 schrieb Christian König: > >>> Am 30.11.20 um 16:30 schrieb Daniel Vetter: >

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Thomas Zimmermann
Hi Am 01.12.20 um 10:10 schrieb Daniel Vetter: On Tue, Dec 1, 2020 at 9:32 AM Thomas Zimmermann wrote: Hi Am 30.11.20 um 16:33 schrieb Christian König: Am 30.11.20 um 16:30 schrieb Daniel Vetter: On Mon, Nov 30, 2020 at 01:04:26PM +0100, Thomas Zimmermann wrote: Mapping a GEM object's buf

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Thomas Zimmermann
Hi Am 01.12.20 um 10:13 schrieb Christian König: Am 01.12.20 um 09:32 schrieb Thomas Zimmermann: Hi Am 30.11.20 um 16:33 schrieb Christian König: Am 30.11.20 um 16:30 schrieb Daniel Vetter: On Mon, Nov 30, 2020 at 01:04:26PM +0100, Thomas Zimmermann wrote: Mapping a GEM object's buffer into

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Christian König
Am 01.12.20 um 09:32 schrieb Thomas Zimmermann: Hi Am 30.11.20 um 16:33 schrieb Christian König: Am 30.11.20 um 16:30 schrieb Daniel Vetter: On Mon, Nov 30, 2020 at 01:04:26PM +0100, Thomas Zimmermann wrote: Mapping a GEM object's buffer into kernel address space prevents the buffer from bein

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Daniel Vetter
On Tue, Dec 1, 2020 at 9:32 AM Thomas Zimmermann wrote: > > Hi > > Am 30.11.20 um 16:33 schrieb Christian König: > > Am 30.11.20 um 16:30 schrieb Daniel Vetter: > >> On Mon, Nov 30, 2020 at 01:04:26PM +0100, Thomas Zimmermann wrote: > >>> Mapping a GEM object's buffer into kernel address space pre

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Thomas Zimmermann
Hi Am 30.11.20 um 16:33 schrieb Christian König: Am 30.11.20 um 16:30 schrieb Daniel Vetter: On Mon, Nov 30, 2020 at 01:04:26PM +0100, Thomas Zimmermann wrote: Mapping a GEM object's buffer into kernel address space prevents the buffer from being evicted from VRAM, which in turn may result in

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-12-01 Thread Thomas Zimmermann
Am 30.11.20 um 16:30 schrieb Daniel Vetter: On Mon, Nov 30, 2020 at 01:04:26PM +0100, Thomas Zimmermann wrote: Mapping a GEM object's buffer into kernel address space prevents the buffer from being evicted from VRAM, which in turn may result in out-of-memory errors. It's therefore required to

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-11-30 Thread Christian König
Am 30.11.20 um 16:30 schrieb Daniel Vetter: On Mon, Nov 30, 2020 at 01:04:26PM +0100, Thomas Zimmermann wrote: Mapping a GEM object's buffer into kernel address space prevents the buffer from being evicted from VRAM, which in turn may result in out-of-memory errors. It's therefore required to on

Re: [PATCH 1/8] drm/gem: Write down some rules for vmap usage

2020-11-30 Thread Daniel Vetter
On Mon, Nov 30, 2020 at 01:04:26PM +0100, Thomas Zimmermann wrote: > Mapping a GEM object's buffer into kernel address space prevents the > buffer from being evicted from VRAM, which in turn may result in > out-of-memory errors. It's therefore required to only vmap GEM BOs for > short periods of ti