Re: [PATCH 1/6] drm/sched: Add internal job peek/pop API

2025-02-18 Thread Tvrtko Ursulin
On 18/02/2025 08:12, Philipp Stanner wrote: On Thu, 2025-02-13 at 14:05 -0800, Matthew Brost wrote: On Wed, Feb 12, 2025 at 01:36:58PM +0100, Philipp Stanner wrote: On Wed, 2025-02-12 at 12:30 +, Tvrtko Ursulin wrote: On 12/02/2025 10:40, Philipp Stanner wrote: On Wed, 2025-02-12 at 09

Re: [PATCH 1/6] drm/sched: Add internal job peek/pop API

2025-02-18 Thread Philipp Stanner
On Thu, 2025-02-13 at 14:05 -0800, Matthew Brost wrote: > On Wed, Feb 12, 2025 at 01:36:58PM +0100, Philipp Stanner wrote: > > On Wed, 2025-02-12 at 12:30 +, Tvrtko Ursulin wrote: > > > > > > On 12/02/2025 10:40, Philipp Stanner wrote: > > > > On Wed, 2025-02-12 at 09:32 +, Tvrtko Ursulin

Re: [PATCH 1/6] drm/sched: Add internal job peek/pop API

2025-02-13 Thread Matthew Brost
On Wed, Feb 12, 2025 at 01:36:58PM +0100, Philipp Stanner wrote: > On Wed, 2025-02-12 at 12:30 +, Tvrtko Ursulin wrote: > > > > On 12/02/2025 10:40, Philipp Stanner wrote: > > > On Wed, 2025-02-12 at 09:32 +, Tvrtko Ursulin wrote: > > > > > > > > On 12/02/2025 09:02, Philipp Stanner wrote

Re: [PATCH 1/6] drm/sched: Add internal job peek/pop API

2025-02-12 Thread Philipp Stanner
On Wed, 2025-02-12 at 12:30 +, Tvrtko Ursulin wrote: > > On 12/02/2025 10:40, Philipp Stanner wrote: > > On Wed, 2025-02-12 at 09:32 +, Tvrtko Ursulin wrote: > > > > > > On 12/02/2025 09:02, Philipp Stanner wrote: > > > > On Fri, 2025-02-07 at 14:50 +, Tvrtko Ursulin wrote: > > > > >

Re: [PATCH 1/6] drm/sched: Add internal job peek/pop API

2025-02-12 Thread Tvrtko Ursulin
On 12/02/2025 10:40, Philipp Stanner wrote: On Wed, 2025-02-12 at 09:32 +, Tvrtko Ursulin wrote: On 12/02/2025 09:02, Philipp Stanner wrote: On Fri, 2025-02-07 at 14:50 +, Tvrtko Ursulin wrote: Idea is to add helpers for peeking and popping jobs from entities with the goal of decoup

Re: [PATCH 1/6] drm/sched: Add internal job peek/pop API

2025-02-12 Thread Philipp Stanner
On Wed, 2025-02-12 at 09:32 +, Tvrtko Ursulin wrote: > > On 12/02/2025 09:02, Philipp Stanner wrote: > > On Fri, 2025-02-07 at 14:50 +, Tvrtko Ursulin wrote: > > > Idea is to add helpers for peeking and popping jobs from entities > > > with > > > the goal of decoupling the hidden assumptio

Re: [PATCH 1/6] drm/sched: Add internal job peek/pop API

2025-02-12 Thread Tvrtko Ursulin
On 12/02/2025 09:02, Philipp Stanner wrote: On Fri, 2025-02-07 at 14:50 +, Tvrtko Ursulin wrote: Idea is to add helpers for peeking and popping jobs from entities with the goal of decoupling the hidden assumption in the code that queue_node is the first element in struct drm_sched_job. Th

Re: [PATCH 1/6] drm/sched: Add internal job peek/pop API

2025-02-12 Thread Philipp Stanner
On Fri, 2025-02-07 at 14:50 +, Tvrtko Ursulin wrote: > Idea is to add helpers for peeking and popping jobs from entities > with > the goal of decoupling the hidden assumption in the code that > queue_node > is the first element in struct drm_sched_job. > > That assumption usually comes in the