Re: [PATCH 1/5] drm/sched: Optimise drm_sched_entity_push_job

2024-10-16 Thread Philipp Stanner
On Wed, 2024-10-16 at 08:41 +0100, Tvrtko Ursulin wrote: > > On 15/10/2024 15:00, Philipp Stanner wrote: > > > [...] > > > How about this: > > > > > > """ > > > In FIFO mode (which is the default), both > > > drm_sched_entity_push_job() > > > and drm_sched_rq_update_fifo(), where the latter calls

Re: [PATCH 1/5] drm/sched: Optimise drm_sched_entity_push_job

2024-10-16 Thread Tvrtko Ursulin
On 15/10/2024 15:00, Philipp Stanner wrote: On Tue, 2024-10-15 at 14:14 +0100, Tvrtko Ursulin wrote: On 15/10/2024 12:38, Philipp Stanner wrote: On Tue, 2024-10-15 at 09:12 +0100, Tvrtko Ursulin wrote: On 15/10/2024 08:11, Philipp Stanner wrote: On Mon, 2024-10-14 at 13:07 +0100, Tvrtko U

Re: [PATCH 1/5] drm/sched: Optimise drm_sched_entity_push_job

2024-10-15 Thread Philipp Stanner
On Tue, 2024-10-15 at 14:14 +0100, Tvrtko Ursulin wrote: > > On 15/10/2024 12:38, Philipp Stanner wrote: > > On Tue, 2024-10-15 at 09:12 +0100, Tvrtko Ursulin wrote: > > > > > > On 15/10/2024 08:11, Philipp Stanner wrote: > > > > On Mon, 2024-10-14 at 13:07 +0100, Tvrtko Ursulin wrote: > > > > >

Re: [PATCH 1/5] drm/sched: Optimise drm_sched_entity_push_job

2024-10-15 Thread Tvrtko Ursulin
On 15/10/2024 12:38, Philipp Stanner wrote: On Tue, 2024-10-15 at 09:12 +0100, Tvrtko Ursulin wrote: On 15/10/2024 08:11, Philipp Stanner wrote: On Mon, 2024-10-14 at 13:07 +0100, Tvrtko Ursulin wrote: On 14/10/2024 12:32, Philipp Stanner wrote: Hi, On Mon, 2024-10-14 at 11:46 +0100, Tvr

Re: [PATCH 1/5] drm/sched: Optimise drm_sched_entity_push_job

2024-10-15 Thread Philipp Stanner
On Tue, 2024-10-15 at 09:12 +0100, Tvrtko Ursulin wrote: > > On 15/10/2024 08:11, Philipp Stanner wrote: > > On Mon, 2024-10-14 at 13:07 +0100, Tvrtko Ursulin wrote: > > > > > > On 14/10/2024 12:32, Philipp Stanner wrote: > > > > Hi, > > > > > > > > On Mon, 2024-10-14 at 11:46 +0100, Tvrtko Ursu

Re: [PATCH 1/5] drm/sched: Optimise drm_sched_entity_push_job

2024-10-15 Thread Tvrtko Ursulin
On 15/10/2024 08:11, Philipp Stanner wrote: On Mon, 2024-10-14 at 13:07 +0100, Tvrtko Ursulin wrote: On 14/10/2024 12:32, Philipp Stanner wrote: Hi, On Mon, 2024-10-14 at 11:46 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In FIFO mode We can avoid dropping the lock only to immediate

Re: [PATCH 1/5] drm/sched: Optimise drm_sched_entity_push_job

2024-10-15 Thread Philipp Stanner
On Mon, 2024-10-14 at 13:07 +0100, Tvrtko Ursulin wrote: > > On 14/10/2024 12:32, Philipp Stanner wrote: > > Hi, > > > > On Mon, 2024-10-14 at 11:46 +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > In FIFO mode We can avoid dropping the lock only to immediately > > > re- > >

Re: [PATCH 1/5] drm/sched: Optimise drm_sched_entity_push_job

2024-10-14 Thread Tvrtko Ursulin
On 14/10/2024 12:32, Philipp Stanner wrote: Hi, On Mon, 2024-10-14 at 11:46 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In FIFO mode We can avoid dropping the lock only to immediately re- acquire by adding a new drm_sched_rq_update_fifo_locked() helper. Please write detailed commit

Re: [PATCH 1/5] drm/sched: Optimise drm_sched_entity_push_job

2024-10-14 Thread Philipp Stanner
Hi, On Mon, 2024-10-14 at 11:46 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In FIFO mode We can avoid dropping the lock only to immediately re- > acquire > by adding a new drm_sched_rq_update_fifo_locked() helper. > Please write detailed commit messages, as described here [1]. 1