Re: [PATCH 1/3] drm/vkms: Add basic CRTC initialization

2018-05-16 Thread Rodrigo Siqueira
Now I got it! I will split the patch and apply your suggestions :) Thanks On 05/16, Daniel Vetter wrote: > On Wed, May 16, 2018 at 5:40 PM, Daniel Vetter wrote: > > On Wed, May 16, 2018 at 4:51 PM, Rodrigo Siqueira > > wrote: > >> Hi Daniel, > >> > >> Thanks for the feedback :) > >> > >> You can

Re: [PATCH 1/3] drm/vkms: Add basic CRTC initialization

2018-05-16 Thread Daniel Vetter
On Wed, May 16, 2018 at 5:40 PM, Daniel Vetter wrote: > On Wed, May 16, 2018 at 4:51 PM, Rodrigo Siqueira > wrote: >> Hi Daniel, >> >> Thanks for the feedback :) >> >> You can find my comments below: >> >> On 05/16, Daniel Vetter wrote: >>> On Wed, May 16, 2018 at 12:06:54AM -0300, Rodrigo Siquei

Re: [PATCH 1/3] drm/vkms: Add basic CRTC initialization

2018-05-16 Thread Daniel Vetter
On Wed, May 16, 2018 at 4:51 PM, Rodrigo Siqueira wrote: > Hi Daniel, > > Thanks for the feedback :) > > You can find my comments below: > > On 05/16, Daniel Vetter wrote: >> On Wed, May 16, 2018 at 12:06:54AM -0300, Rodrigo Siqueira wrote: >> > This commit adds the essential infrastructure for ma

Re: [PATCH 1/3] drm/vkms: Add basic CRTC initialization

2018-05-16 Thread Rodrigo Siqueira
Hi Daniel, Thanks for the feedback :) You can find my comments below: On 05/16, Daniel Vetter wrote: > On Wed, May 16, 2018 at 12:06:54AM -0300, Rodrigo Siqueira wrote: > > This commit adds the essential infrastructure for managing CRTCs which > > is composed of: a new data struct for output dat

Re: [PATCH 1/3] drm/vkms: Add basic CRTC initialization

2018-05-16 Thread Daniel Vetter
On Wed, May 16, 2018 at 12:06:54AM -0300, Rodrigo Siqueira wrote: > This commit adds the essential infrastructure for managing CRTCs which > is composed of: a new data struct for output data information, a > function for basic modeset initialization, and the operation to create > planes. Due to the