Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-20 Thread Daniel Vetter
On Fri, Mar 17, 2017 at 11:00:44AM -0300, Gustavo Padovan wrote: > 2017-03-16 Philipp Zabel : > > > Hi Gustavo, > > > > On Mon, 2017-03-13 at 14:37 -0300, Gustavo Padovan wrote: > > [...] > > > I was thinking on some function that would iterate over all fences in > > > the fence_array and check t

Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-19 Thread Lucas Stach
Am Samstag, den 18.03.2017, 15:19 +0100 schrieb Christian König: > Am 17.03.2017 um 15:58 schrieb Lucas Stach: > > Am Freitag, den 17.03.2017, 14:42 + schrieb Russell King - ARM > > Linux: > > > On Fri, Mar 17, 2017 at 03:10:21PM +0100, Lucas Stach wrote: > > > > Am Donnerstag, den 16.03.2017,

Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-18 Thread Christian König
Am 17.03.2017 um 15:58 schrieb Lucas Stach: Am Freitag, den 17.03.2017, 14:42 + schrieb Russell King - ARM Linux: On Fri, Mar 17, 2017 at 03:10:21PM +0100, Lucas Stach wrote: Am Donnerstag, den 16.03.2017, 12:05 +0100 schrieb Philipp Zabel: Hi Gustavo, On Mon, 2017-03-13 at 14:37 -0300, G

Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-17 Thread Chris Healy
On Fri, Mar 17, 2017 at 7:58 AM, Lucas Stach wrote: > Am Freitag, den 17.03.2017, 14:42 + schrieb Russell King - ARM > Linux: >> On Fri, Mar 17, 2017 at 03:10:21PM +0100, Lucas Stach wrote: >> > Am Donnerstag, den 16.03.2017, 12:05 +0100 schrieb Philipp Zabel: >> > > Hi Gustavo, >> > > >> > >

Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-17 Thread Russell King - ARM Linux
On Fri, Mar 17, 2017 at 03:58:27PM +0100, Lucas Stach wrote: > Am Freitag, den 17.03.2017, 14:42 + schrieb Russell King - ARM > Linux: > > On Fri, Mar 17, 2017 at 03:10:21PM +0100, Lucas Stach wrote: > > > Am Donnerstag, den 16.03.2017, 12:05 +0100 schrieb Philipp Zabel: > > > > Hi Gustavo, > >

Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-17 Thread Russell King - ARM Linux
On Fri, Mar 17, 2017 at 03:10:21PM +0100, Lucas Stach wrote: > Am Donnerstag, den 16.03.2017, 12:05 +0100 schrieb Philipp Zabel: > > Hi Gustavo, > > > > On Mon, 2017-03-13 at 14:37 -0300, Gustavo Padovan wrote: > > [...] > > > I was thinking on some function that would iterate over all fences in >

Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-17 Thread Lucas Stach
Am Freitag, den 17.03.2017, 14:42 + schrieb Russell King - ARM Linux: > On Fri, Mar 17, 2017 at 03:10:21PM +0100, Lucas Stach wrote: > > Am Donnerstag, den 16.03.2017, 12:05 +0100 schrieb Philipp Zabel: > > > Hi Gustavo, > > > > > > On Mon, 2017-03-13 at 14:37 -0300, Gustavo Padovan wrote: > >

Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-17 Thread Lucas Stach
Am Freitag, den 17.03.2017, 15:09 +0100 schrieb Philipp Zabel: > On Fri, 2017-03-17 at 10:55 -0300, Gustavo Padovan wrote: > > 2017-03-16 Rob Clark : > > > > > On Wed, Mar 8, 2017 at 9:37 AM, Gustavo Padovan > > > wrote: > > > >> diff --git a/include/uapi/drm/etnaviv_drm.h > > > >> b/include/ua

Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-17 Thread Lucas Stach
Am Donnerstag, den 16.03.2017, 12:05 +0100 schrieb Philipp Zabel: > Hi Gustavo, > > On Mon, 2017-03-13 at 14:37 -0300, Gustavo Padovan wrote: > [...] > > I was thinking on some function that would iterate over all fences in > > the fence_array and check their context. The if we find our own gpu >

Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-17 Thread Philipp Zabel
On Fri, 2017-03-17 at 10:55 -0300, Gustavo Padovan wrote: > 2017-03-16 Rob Clark : > > > On Wed, Mar 8, 2017 at 9:37 AM, Gustavo Padovan wrote: > > >> diff --git a/include/uapi/drm/etnaviv_drm.h > > >> b/include/uapi/drm/etnaviv_drm.h > > >> index 2584c1cca42f6..e9c388a1d8ebe 100644 > > >> --- a

Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-17 Thread Philipp Zabel
On Fri, 2017-03-17 at 11:00 -0300, Gustavo Padovan wrote: > 2017-03-16 Philipp Zabel : > > > Hi Gustavo, > > > > On Mon, 2017-03-13 at 14:37 -0300, Gustavo Padovan wrote: > > [...] > > > I was thinking on some function that would iterate over all fences in > > > the fence_array and check their co

Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-17 Thread Gustavo Padovan
2017-03-16 Philipp Zabel : > Hi Gustavo, > > On Mon, 2017-03-13 at 14:37 -0300, Gustavo Padovan wrote: > [...] > > I was thinking on some function that would iterate over all fences in > > the fence_array and check their context. The if we find our own gpu > > context in there we fail the submit.

Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-17 Thread Gustavo Padovan
2017-03-16 Rob Clark : > On Wed, Mar 8, 2017 at 9:37 AM, Gustavo Padovan wrote: > >> diff --git a/include/uapi/drm/etnaviv_drm.h > >> b/include/uapi/drm/etnaviv_drm.h > >> index 2584c1cca42f6..e9c388a1d8ebe 100644 > >> --- a/include/uapi/drm/etnaviv_drm.h > >> +++ b/include/uapi/drm/etnaviv_drm.

Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-16 Thread Rob Clark
On Wed, Mar 8, 2017 at 9:37 AM, Gustavo Padovan wrote: >> diff --git a/include/uapi/drm/etnaviv_drm.h b/include/uapi/drm/etnaviv_drm.h >> index 2584c1cca42f6..e9c388a1d8ebe 100644 >> --- a/include/uapi/drm/etnaviv_drm.h >> +++ b/include/uapi/drm/etnaviv_drm.h >> @@ -154,6 +154,10 @@ struct drm_etn

Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-16 Thread Philipp Zabel
Hi Gustavo, On Mon, 2017-03-13 at 14:37 -0300, Gustavo Padovan wrote: [...] > I was thinking on some function that would iterate over all fences in > the fence_array and check their context. The if we find our own gpu > context in there we fail the submit. Why would we have to fail if somebody fe

Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-13 Thread Gustavo Padovan
Hi Philipp, 2017-03-13 Philipp Zabel : > Hi Gustavo, > > thank you for the review. > > On Wed, 2017-03-08 at 11:37 -0300, Gustavo Padovan wrote: > [...] > > > @@ -385,6 +396,25 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, > > > void *data, > > > goto err_submit_objects; >

Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-13 Thread Philipp Zabel
Hi Gustavo, thank you for the review. On Wed, 2017-03-08 at 11:37 -0300, Gustavo Padovan wrote: [...] > > @@ -385,6 +396,25 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, > > void *data, > > goto err_submit_objects; > > } > > > > + if (args->flags & ETNA_SUBMIT_FENCE

Re: [PATCH 1/3] drm/etnaviv: submit support for in-fences

2017-03-08 Thread Gustavo Padovan
Hi Philipp, 2017-03-08 Philipp Zabel : > Loosely based on commit f0a42bb5423a ("drm/msm: submit support for > in-fences"). Unfortunately, struct drm_etnaviv_gem_submit doesn't have > a flags field yet, so we have to extend the structure and trust that > drm_ioctl will clear the flags for us if an