Re: [PATCH 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-07-28 Thread Alex Lanzano
On Sun, Jul 28, 2024 at 04:43:42PM GMT, Krzysztof Kozlowski wrote: > On 28/07/2024 14:56, Alex Lanzano wrote: > > + > > + spi-cs-high: true > > You can drop it. > > >>> > >>> This is a required property in order for the display to function > >>> correctly. > >>> But I have

Re: [PATCH 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-07-28 Thread Krzysztof Kozlowski
On 28/07/2024 14:56, Alex Lanzano wrote: > + > + spi-cs-high: true You can drop it. >>> >>> This is a required property in order for the display to function correctly. >>> But I have no issues removing it if there's a better place to document it. >> >> The sharp LCD device o

Re: [PATCH 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-07-28 Thread Alex Lanzano
On Sun, Jul 28, 2024 at 10:40:23AM GMT, Krzysztof Kozlowski wrote: > On 27/07/2024 18:30, Alex Lanzano wrote: > > On Thu, Jul 25, 2024 at 08:17:01AM GMT, Krzysztof Kozlowski wrote: > >> On 25/07/2024 02:47, Alex Lanzano wrote: > >>> + > >>> +properties: > >>> + compatible: > >>> +enum: > >>> +

Re: [PATCH 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-07-28 Thread Krzysztof Kozlowski
On 27/07/2024 18:30, Alex Lanzano wrote: > On Thu, Jul 25, 2024 at 08:17:01AM GMT, Krzysztof Kozlowski wrote: >> On 25/07/2024 02:47, Alex Lanzano wrote: >>> + >>> +properties: >>> + compatible: >>> +enum: >>> + - sharp,ls010b7dh04 >>> + - sharp,ls011b7dh03 >>> + - sharp,ls012b7

Re: [PATCH 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-07-27 Thread Alex Lanzano
On Thu, Jul 25, 2024 at 08:17:01AM GMT, Krzysztof Kozlowski wrote: > On 25/07/2024 02:47, Alex Lanzano wrote: > > + > > +properties: > > + compatible: > > +enum: > > + - sharp,ls010b7dh04 > > + - sharp,ls011b7dh03 > > + - sharp,ls012b7dd01 > > + - sharp,ls013b7dh03 > > +

Re: [PATCH 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-07-25 Thread Alex Lanzano
On Thu, Jul 25, 2024 at 08:18:44AM GMT, Krzysztof Kozlowski wrote: > On 25/07/2024 02:47, Alex Lanzano wrote: > > Add device tree bindings for the monochrome Sharp Memory LCD > > > > Signed-off-by: Alex Lanzano > > --- > > .../bindings/display/sharp,sharp-memory.yaml | 97 +++ >

Re: [PATCH 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-07-25 Thread Alex Lanzano
Thank you for the review! I will address these comments in V2 On Thu, Jul 25, 2024 at 08:17:01AM GMT, Krzysztof Kozlowski wrote: > On 25/07/2024 02:47, Alex Lanzano wrote: > > Add device tree bindings for the monochrome Sharp Memory LCD > > > > Signed-off-by: Alex Lanzano > > --- > > .../bindin

Re: [PATCH 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-07-24 Thread Krzysztof Kozlowski
On 25/07/2024 02:47, Alex Lanzano wrote: > Add device tree bindings for the monochrome Sharp Memory LCD > > Signed-off-by: Alex Lanzano > --- > .../bindings/display/sharp,sharp-memory.yaml | 97 +++ > include/dt-bindings/display/sharp-memory.h| 9 ++ > 2 files changed, 106

Re: [PATCH 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-07-24 Thread Krzysztof Kozlowski
On 25/07/2024 02:47, Alex Lanzano wrote: > Add device tree bindings for the monochrome Sharp Memory LCD > > Signed-off-by: Alex Lanzano > --- > .../bindings/display/sharp,sharp-memory.yaml | 97 +++ > include/dt-bindings/display/sharp-memory.h| 9 ++ > 2 files changed, 106