Re: [PATCH 1/2] drm: fix drm_vm for NOMMU builds

2017-01-11 Thread Benjamin Gaignard
2017-01-11 17:59 GMT+01:00 Arnd Bergmann : > On Wed, Jan 11, 2017 at 5:36 PM, Daniel Vetter wrote: >> On Wed, Jan 11, 2017 at 5:33 PM, Arnd Bergmann wrote: >>> CONFIG_DRM_VM=y >> >> Does randconfig just set this for fun, despite that it's a hidden >> Kconfig symbol? Should we add a depends !NOMMU

Re: [PATCH 1/2] drm: fix drm_vm for NOMMU builds

2017-01-11 Thread Arnd Bergmann
On Wed, Jan 11, 2017 at 5:36 PM, Daniel Vetter wrote: > On Wed, Jan 11, 2017 at 5:33 PM, Arnd Bergmann wrote: >> CONFIG_DRM_VM=y > > Does randconfig just set this for fun, despite that it's a hidden > Kconfig symbol? Should we add a depends !NOMMU to it to make sure it > never gets enabled when i

Re: [PATCH 1/2] drm: fix drm_vm for NOMMU builds

2017-01-11 Thread Daniel Vetter
On Wed, Jan 11, 2017 at 5:33 PM, Arnd Bergmann wrote: > On Wednesday, January 11, 2017 5:27:13 PM CET Daniel Vetter wrote: >> On Wed, Jan 11, 2017 at 02:33:34PM +0100, Arnd Bergmann wrote: >> > When building DRM without an MMU, we run into a compile-time error because >> > pte_wrprotect() is not d

Re: [PATCH 1/2] drm: fix drm_vm for NOMMU builds

2017-01-11 Thread Arnd Bergmann
On Wednesday, January 11, 2017 5:27:13 PM CET Daniel Vetter wrote: > On Wed, Jan 11, 2017 at 02:33:34PM +0100, Arnd Bergmann wrote: > > When building DRM without an MMU, we run into a compile-time error because > > pte_wrprotect() is not defined: > > > > drivers/gpu/drm/drm_vm.c: In function 'drm_

Re: [PATCH 1/2] drm: fix drm_vm for NOMMU builds

2017-01-11 Thread Daniel Vetter
On Wed, Jan 11, 2017 at 02:33:34PM +0100, Arnd Bergmann wrote: > When building DRM without an MMU, we run into a compile-time error because > pte_wrprotect() is not defined: > > drivers/gpu/drm/drm_vm.c: In function 'drm_mmap_dma': > drivers/gpu/drm/drm_vm.c:496:9: error: implicit declaration of f