Re: [PATCH 1/2] drm/atomic: Pass the full state to CRTC atomic_check

2020-11-02 Thread Maxime Ripard
Hi, On Mon, Nov 02, 2020 at 09:09:44AM +0100, Thomas Zimmermann wrote: > I read through the patch and it looks correct to me. The naming is a bit > off at times. For example, ast_state should now probably be called > ast_crtc_state. But that's not a blocker IMHO. Yeah, a few places have odd names

Re: [PATCH 1/2] drm/atomic: Pass the full state to CRTC atomic_check

2020-11-02 Thread Thomas Zimmermann
Hi Am 28.10.20 um 13:32 schrieb Maxime Ripard: > The current atomic helpers have either their object state being passed as > an argument or the full atomic state. > > The former is the pattern that was done at first, before switching to the > latter for new hooks or when it was needed. > > Let's

Re: [PATCH 1/2] drm/atomic: Pass the full state to CRTC atomic_check

2020-11-01 Thread Maxime Ripard
Hi! Thanks for reviewing those patches On Thu, Oct 29, 2020 at 03:50:41PM +0200, Ville Syrjälä wrote: > On Wed, Oct 28, 2020 at 01:32:21PM +0100, Maxime Ripard wrote: > > The current atomic helpers have either their object state being passed as > > an argument or the full atomic state. > > > > T

Re: [PATCH 1/2] drm/atomic: Pass the full state to CRTC atomic_check

2020-10-29 Thread Ville Syrjälä
On Wed, Oct 28, 2020 at 01:32:21PM +0100, Maxime Ripard wrote: > The current atomic helpers have either their object state being passed as > an argument or the full atomic state. > > The former is the pattern that was done at first, before switching to the > latter for new hooks or when it was nee