Re: [PATCH 1/1] fbdev: atyfb: Fix buffer overflow

2025-04-01 Thread Ville Syrjälä
On Tue, Apr 01, 2025 at 01:23:30PM +0300, Denis Arefev wrote: > > It's old, but still runs in some configurations and people > > still (although probably not on daily bases) use it. > > Also don't forget about the various old non-x86 hardware machines > > which often used ATI cards too, and those m

Re: [PATCH 1/1] fbdev: atyfb: Fix buffer overflow

2025-04-01 Thread Denis Arefev
> It's old, but still runs in some configurations and people > still (although probably not on daily bases) use it. > Also don't forget about the various old non-x86 hardware machines > which often used ATI cards too, and those machines are still > supported by Linux as well. Hi Helge. Thanks for

Re: [PATCH 1/1] fbdev: atyfb: Fix buffer overflow

2025-04-01 Thread Helge Deller
On 4/1/25 10:40, Denis Arefev wrote: One small question. This chip (3D RAGE LT (Mach64 LG)) is very old it is 25 or maybe 30 years old, why is it not removed from the core? It's old, but still runs in some configurations and people still (although probably not on daily bases) use it. Also don't

Re: [PATCH 1/1] fbdev: atyfb: Fix buffer overflow

2025-04-01 Thread Denis Arefev
Hi Ville. Hi Jani. Thank you for your answers. One small question. This chip (3D RAGE LT (Mach64 LG)) is very old it is 25 or maybe 30 years old, why is it not removed from the core? Regards Denis.

Re: [PATCH 1/1] fbdev: atyfb: Fix buffer overflow

2025-03-31 Thread Ville Syrjälä
On Thu, Mar 27, 2025 at 12:14:26PM +0200, Jani Nikula wrote: > On Thu, 27 Mar 2025, Denis Arefev wrote: > > The value LCD_MISC_CNTL is used in the 'aty_st_lcd()' function to > > calculate an index for accessing an array element of size 9. > > This may cause a buffer overflow. > > The fix is to fi

Re: [PATCH 1/1] fbdev: atyfb: Fix buffer overflow

2025-03-27 Thread Jani Nikula
On Thu, 27 Mar 2025, Denis Arefev wrote: > The value LCD_MISC_CNTL is used in the 'aty_st_lcd()' function to > calculate an index for accessing an array element of size 9. > This may cause a buffer overflow. The fix is to fix it, not silently brush it under the carpet. BR, Jani. > > Found by Li