Re: [PATCH 09/32] auxdisplay/ht16k33: Set FBINFO_VIRTFB flag

2023-11-22 Thread Thomas Zimmermann
Hi Am 22.11.23 um 00:50 schrieb Miguel Ojeda: On Wed, Nov 15, 2023 at 11:30 AM Thomas Zimmermann wrote: + fbdev->info->flags |= FBINFO_VIRTFB; Is the `|=` (instead of just `=`) used in case someone adds something to the flags before (e.g. `fb_bl_default_curve`) or due to some other re

Re: [PATCH 09/32] auxdisplay/ht16k33: Set FBINFO_VIRTFB flag

2023-11-21 Thread Robin van der Gracht
On 2023-11-15 11:19, Thomas Zimmermann wrote: The ht16k33 driver operates on system memory. Mark the framebuffer accordingly. Helpers operating on the framebuffer memory will test for the presence of this flag. Signed-off-by: Thomas Zimmermann Cc: Miguel Ojeda Cc: Robin van der Gracht --- dr

Re: [PATCH 09/32] auxdisplay/ht16k33: Set FBINFO_VIRTFB flag

2023-11-21 Thread Miguel Ojeda
On Wed, Nov 15, 2023 at 11:30 AM Thomas Zimmermann wrote: > > + fbdev->info->flags |= FBINFO_VIRTFB; Is the `|=` (instead of just `=`) used in case someone adds something to the flags before (e.g. `fb_bl_default_curve`) or due to some other reason? (One of the other patches uses `=`). In a

Re: [PATCH 09/32] auxdisplay/ht16k33: Set FBINFO_VIRTFB flag

2023-11-16 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > The ht16k33 driver operates on system memory. Mark the framebuffer > accordingly. Helpers operating on the framebuffer memory will test > for the presence of this flag. > > Signed-off-by: Thomas Zimmermann > Cc: Miguel Ojeda > Cc: Robin van der Gracht > --- > drive