Re: [PATCH 08/44] drm/vboxvideo: Stop using drm_device->dev_private

2020-04-08 Thread Sam Ravnborg
On Fri, Apr 03, 2020 at 03:57:52PM +0200, Daniel Vetter wrote: > We use the baseclass pattern here, so lets to the proper (and more > typesafe) upcasting. > > Signed-off-by: Daniel Vetter > Cc: Hans de Goede Acked-by: Sam Ravnborg As for naming discussed in other mail I had gone for to_vbox()

Re: [PATCH 08/44] drm/vboxvideo: Stop using drm_device->dev_private

2020-04-07 Thread Thomas Zimmermann
Hi Am 07.04.20 um 09:24 schrieb Daniel Vetter: > On Mon, Apr 6, 2020 at 7:27 PM Thomas Zimmermann wrote: >> >> Hi >> >> Am 03.04.20 um 15:57 schrieb Daniel Vetter: >>> We use the baseclass pattern here, so lets to the proper (and more >>> typesafe) upcasting. >>> >>> Signed-off-by: Daniel Vetter

Re: [PATCH 08/44] drm/vboxvideo: Stop using drm_device->dev_private

2020-04-07 Thread Daniel Vetter
On Mon, Apr 6, 2020 at 7:27 PM Thomas Zimmermann wrote: > > Hi > > Am 03.04.20 um 15:57 schrieb Daniel Vetter: > > We use the baseclass pattern here, so lets to the proper (and more > > typesafe) upcasting. > > > > Signed-off-by: Daniel Vetter > > Cc: Hans de Goede > > --- > > drivers/gpu/drm/v

Re: [PATCH 08/44] drm/vboxvideo: Stop using drm_device->dev_private

2020-04-06 Thread Thomas Zimmermann
Hi Am 03.04.20 um 15:57 schrieb Daniel Vetter: > We use the baseclass pattern here, so lets to the proper (and more > typesafe) upcasting. > > Signed-off-by: Daniel Vetter > Cc: Hans de Goede > --- > drivers/gpu/drm/vboxvideo/vbox_drv.c | 1 - > drivers/gpu/drm/vboxvideo/vbox_drv.h | 1 + >