Re: [PATCH 04/24] drm/vgem: Use devm_drm_dev_alloc

2020-09-09 Thread Melissa Wen
On 09/09, Daniel Vetter wrote: > On Wed, Sep 9, 2020 at 1:01 PM Melissa Wen wrote: > > > > Hi Daniel, > > > > looks good to me, just a few things inline. > > > > On 09/04, Daniel Vetter wrote: > > > This means we also need to slightly restructure the exit code, so that > > > final cleanup of the d

Re: [PATCH 04/24] drm/vgem: Use devm_drm_dev_alloc

2020-09-09 Thread Daniel Vetter
On Wed, Sep 9, 2020 at 1:01 PM Melissa Wen wrote: > > Hi Daniel, > > looks good to me, just a few things inline. > > On 09/04, Daniel Vetter wrote: > > This means we also need to slightly restructure the exit code, so that > > final cleanup of the drm_device is triggered by unregistering the > > p

Re: [PATCH 04/24] drm/vgem: Use devm_drm_dev_alloc

2020-09-09 Thread Melissa Wen
Hi Daniel, looks good to me, just a few things inline. On 09/04, Daniel Vetter wrote: > This means we also need to slightly restructure the exit code, so that > final cleanup of the drm_device is triggered by unregistering the > platform device. Note that devres is both clean up when the driver i