On 25/04/2024 02:57, Junhao Xie wrote:
On 2024/4/25 03:37, Konrad Dybcio wrote:
On 4/24/24 17:29, Xilin Wu via B4 Relay wrote:
From: Junhao Xie
Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller.
Signed-off-by: Junhao Xie
---
[...]
+ return sn3112_write_reg(priv,
On 2024/4/25 14:02, Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Apr 24, 2024 at 11:29:07PM +0800, Xilin Wu via B4 Relay wrote:
>> From: Junhao Xie
>>
>> Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller.
>>
[...]
>> +MODULE_LICENSE("GPL");
>
> Best regards
> Uwe
>
Than
Hello,
On Wed, Apr 24, 2024 at 09:37:25PM +0200, Konrad Dybcio wrote:
> On 4/24/24 17:29, Xilin Wu via B4 Relay wrote:
> > +
> > + /* use random value to apply changes */
> > + ret = sn3112_write_reg(priv, SN3112_REG_APPLY, 0x66);
>
> "a random value"? sounds suspicious..
I smiled about that
Hello,
On Wed, Apr 24, 2024 at 04:55:26PM +0100, Bryan O'Donoghue wrote:
> On 24/04/2024 16:29, Xilin Wu via B4 Relay wrote:
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
>
> Includes should be alphabetised
Hello,
On Wed, Apr 24, 2024 at 11:29:07PM +0800, Xilin Wu via B4 Relay wrote:
> From: Junhao Xie
>
> Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller.
>
> Signed-off-by: Junhao Xie
Missing S-o-b for patch sender.
> ---
> drivers/pwm/Kconfig | 10 ++
> drivers/
On 2024/4/25 03:37, Konrad Dybcio wrote:
> On 4/24/24 17:29, Xilin Wu via B4 Relay wrote:
>> From: Junhao Xie
>>
>> Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller.
>>
>> Signed-off-by: Junhao Xie
>> ---
>[...]
>> + return sn3112_write_reg(priv, SN3112_REG_PWM_EN + re
On 4/24/24 17:29, Xilin Wu via B4 Relay wrote:
From: Junhao Xie
Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller.
Signed-off-by: Junhao Xie
---
[...]
+static int sn3112_set_en_reg(struct sn3112 *priv, unsigned int channel,
+bool enab
On 24/4/2024 23:55, Bryan O'Donoghue wrote:
> On 24/04/2024 16:29, Xilin Wu via B4 Relay wrote:
>> From: Junhao Xie
>>
>> Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller.
>>
>> Signed-off-by: Junhao Xie
>> ---
>> drivers/pwm/Kconfig | 10 ++
>> drivers/pwm/Makef
On 24/04/2024 16:29, Xilin Wu via B4 Relay wrote:
From: Junhao Xie
Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller.
Signed-off-by: Junhao Xie
---
drivers/pwm/Kconfig | 10 ++
drivers/pwm/Makefile | 1 +
drivers/pwm/pwm-sn3112.c | 336 +
