Re: [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-12 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Thursday, 12 July 2018 11:36:26 EEST Mahesh Kumar wrote: > This patch adds a new callback function "verify_crc_source" which will > be used during setting the crc source in control node. This will help > in avoiding setting of wrong string for source. > > C

Re: [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-10 Thread Kumar, Mahesh
Hi, On 7/10/2018 5:40 PM, Laurent Pinchart wrote: Hi Mahesh, On Tuesday, 10 July 2018 14:54:11 EEST Kumar, Mahesh wrote: On 7/10/2018 4:56 PM, Laurent Pinchart wrote: On Monday, 2 July 2018 14:07:20 EEST Mahesh Kumar wrote: This patch adds a new callback function "verify_crc_source" which w

Re: [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, On Tuesday, 10 July 2018 14:54:11 EEST Kumar, Mahesh wrote: > On 7/10/2018 4:56 PM, Laurent Pinchart wrote: > > On Monday, 2 July 2018 14:07:20 EEST Mahesh Kumar wrote: > >> This patch adds a new callback function "verify_crc_source" which will > >> be used during setting the crc source

Re: [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-10 Thread Kumar, Mahesh
Hi, Thanks for the review, On 7/10/2018 4:56 PM, Laurent Pinchart wrote: Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:20 EEST Mahesh Kumar wrote: This patch adds a new callback function "verify_crc_source" which will be used during setting the crc source in control node an

Re: [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:20 EEST Mahesh Kumar wrote: > This patch adds a new callback function "verify_crc_source" which will > be used during setting the crc source in control node and while opening > data node for crc reading. This will help in avoiding s