Re: [PATCH 0/3] Use implicit kref infra

2020-09-03 Thread Luben Tuikov
On 2020-09-02 9:57 p.m., Pan, Xinhui wrote: > > >> 2020年9月2日 22:50,Tuikov, Luben 写道: >> >> On 2020-09-02 00:43, Pan, Xinhui wrote: >>> >>> 2020年9月2日 11:46,Tuikov, Luben 写道: On 2020-09-01 21:42, Pan, Xinhui wrote: > If you take a look at the below function, you should not use

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Pan, Xinhui
> 2020年9月2日 22:50,Tuikov, Luben 写道: > > On 2020-09-02 00:43, Pan, Xinhui wrote: >> >> >>> 2020年9月2日 11:46,Tuikov, Luben 写道: >>> >>> On 2020-09-01 21:42, Pan, Xinhui wrote: If you take a look at the below function, you should not use driver's release to free adev. As dev is embedd

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Daniel Vetter
On Wed, Sep 2, 2020 at 9:55 PM Daniel Vetter wrote: > > On Wed, Sep 2, 2020 at 9:17 PM Alex Deucher wrote: > > > > On Wed, Sep 2, 2020 at 3:04 PM Luben Tuikov wrote: > > > > > > On 2020-09-02 11:51 a.m., Daniel Stone wrote: > > > > Hi Luben, > > > > > > > > On Wed, 2 Sep 2020 at 16:16, Luben Tui

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Daniel Vetter
On Wed, Sep 2, 2020 at 9:17 PM Alex Deucher wrote: > > On Wed, Sep 2, 2020 at 3:04 PM Luben Tuikov wrote: > > > > On 2020-09-02 11:51 a.m., Daniel Stone wrote: > > > Hi Luben, > > > > > > On Wed, 2 Sep 2020 at 16:16, Luben Tuikov wrote: > > >> Not sure how I can do this when someone doesn't want

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Alex Deucher
On Wed, Sep 2, 2020 at 3:04 PM Luben Tuikov wrote: > > On 2020-09-02 11:51 a.m., Daniel Stone wrote: > > Hi Luben, > > > > On Wed, 2 Sep 2020 at 16:16, Luben Tuikov wrote: > >> Not sure how I can do this when someone doesn't want to read up on > >> the kref infrastructure. Can you help? > >> > >>

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Luben Tuikov
On 2020-09-02 11:51 a.m., Daniel Stone wrote: > Hi Luben, > > On Wed, 2 Sep 2020 at 16:16, Luben Tuikov wrote: >> Not sure how I can do this when someone doesn't want to read up on >> the kref infrastructure. Can you help? >> >> When someone starts off with "My understanding of ..." (as in the OP

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Daniel Stone
Hi Luben, On Wed, 2 Sep 2020 at 16:16, Luben Tuikov wrote: > Not sure how I can do this when someone doesn't want to read up on > the kref infrastructure. Can you help? > > When someone starts off with "My understanding of ..." (as in the OP) you > know you're > in trouble and in for a rough tim

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Luben Tuikov
On 2020-09-02 11:00, Daniel Stone wrote: > Hi Luben, > > On Wed, 2 Sep 2020 at 15:51, Luben Tuikov wrote: >> Of course it's true--good morning! >> >> Let me stop you right there--just read the documentation I pointed >> to you at. >> >> No! >> >> I'm sorry, that doesn't make sense. >> >> No, that

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Luben Tuikov
On 2020-09-02 02:52, Daniel Vetter wrote: > On Tue, Sep 01, 2020 at 11:46:18PM -0400, Luben Tuikov wrote: >> On 2020-09-01 21:42, Pan, Xinhui wrote: >>> If you take a look at the below function, you should not use driver's >>> release to free adev. As dev is embedded in adev. >> >> Do you mean "lo

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Daniel Stone
Hi Luben, On Wed, 2 Sep 2020 at 15:51, Luben Tuikov wrote: > Of course it's true--good morning! > > Let me stop you right there--just read the documentation I pointed > to you at. > > No! > > I'm sorry, that doesn't make sense. > > No, that's horrible. > > No, that's horrible. > > You need to und

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Luben Tuikov
On 2020-09-02 00:43, Pan, Xinhui wrote: > > >> 2020年9月2日 11:46,Tuikov, Luben 写道: >> >> On 2020-09-01 21:42, Pan, Xinhui wrote: >>> If you take a look at the below function, you should not use driver's >>> release to free adev. As dev is embedded in adev. >> >> Do you mean "look at the function

Re: [PATCH 0/3] Use implicit kref infra

2020-09-01 Thread Daniel Vetter
On Tue, Sep 01, 2020 at 11:46:18PM -0400, Luben Tuikov wrote: > On 2020-09-01 21:42, Pan, Xinhui wrote: > > If you take a look at the below function, you should not use driver's > > release to free adev. As dev is embedded in adev. > > Do you mean "look at the function below", using "below" as an

Re: [PATCH 0/3] Use implicit kref infra

2020-09-01 Thread Pan, Xinhui
> 2020年9月2日 11:46,Tuikov, Luben 写道: > > On 2020-09-01 21:42, Pan, Xinhui wrote: >> If you take a look at the below function, you should not use driver's >> release to free adev. As dev is embedded in adev. > > Do you mean "look at the function below", using "below" as an adverb? > "below" is

Re: [PATCH 0/3] Use implicit kref infra

2020-09-01 Thread Luben Tuikov
On 2020-09-01 21:42, Pan, Xinhui wrote: > If you take a look at the below function, you should not use driver's release > to free adev. As dev is embedded in adev. Do you mean "look at the function below", using "below" as an adverb? "below" is not an adjective. I know dev is embedded in adev--I

Re: [PATCH 0/3] Use implicit kref infra

2020-09-01 Thread Pan, Xinhui
If you take a look at the below function, you should not use driver's release to free adev. As dev is embedded in adev. 809 static void drm_dev_release(struct kref *ref) 810 { 811 struct drm_device *dev = container_of(ref, struct drm_device, ref); 812 813 if (dev->dri