Re: [PATCH 0/3] RFC: Common functions for GEM offset creation

2011-08-04 Thread Daniel Vetter
>> On Tue, Jul 19, 2011 at 4:33 AM, Chris Wilson >> wrote: >>> My only concern is that for the common functions the mmap_offset to create >>> should be passed in a parameter, so that we could support more than one >>> mapping for an object. [ snip ] > On Tue, Jul 19, 2011 at 8:12 AM, Rob Clark

Re: [PATCH 0/3] RFC: Common functions for GEM offset creation

2011-08-04 Thread Rob Clark
On Tue, Jul 19, 2011 at 8:12 AM, Rob Clark wrote: > On Tue, Jul 19, 2011 at 4:33 AM, Chris Wilson > wrote: >> On Mon, 18 Jul 2011 19:20:56 -0500, Rob Clark wrote: >>> In the process of adding GEM support for OMAP DRM driver, I noticed that >>> I was adding code for creating/freeing mmap offsets

Re: [PATCH 0/3] RFC: Common functions for GEM offset creation

2011-07-19 Thread Alan Cox
> ahh, ok.. I should check this out (although I'm not entirely sure > where your gma500 staging tree is) Its in GregKH's staging tree or linux-next. It's basically what you've done so if your patch is submitted it'll take me 2 minutes to fix the gma500 tree. > I'm already using your patch to add

Re: [PATCH 0/3] RFC: Common functions for GEM offset creation

2011-07-19 Thread Rob Clark
On Tue, Jul 19, 2011 at 4:33 AM, Chris Wilson wrote: > On Mon, 18 Jul 2011 19:20:56 -0500, Rob Clark wrote: >> In the process of adding GEM support for OMAP DRM driver, I noticed that >> I was adding code for creating/freeing mmap offsets which was virtually >> identical to what was already dupli

Re: [PATCH 0/3] RFC: Common functions for GEM offset creation

2011-07-19 Thread Rob Clark
On Tue, Jul 19, 2011 at 3:57 AM, Alan Cox wrote: > On Mon, 18 Jul 2011 19:20:56 -0500 > Rob Clark wrote: > >> In the process of adding GEM support for OMAP DRM driver, I noticed that >> I was adding code for creating/freeing mmap offsets which was virtually >> identical to what was already duplic

Re: [PATCH 0/3] RFC: Common functions for GEM offset creation

2011-07-19 Thread Chris Wilson
On Mon, 18 Jul 2011 19:20:56 -0500, Rob Clark wrote: > In the process of adding GEM support for OMAP DRM driver, I noticed that > I was adding code for creating/freeing mmap offsets which was virtually > identical to what was already duplicated in i915 and gma500 drivers. > > Rather than duplicat

Re: [PATCH 0/3] RFC: Common functions for GEM offset creation

2011-07-19 Thread Alan Cox
On Mon, 18 Jul 2011 19:20:56 -0500 Rob Clark wrote: > In the process of adding GEM support for OMAP DRM driver, I noticed that > I was adding code for creating/freeing mmap offsets which was virtually > identical to what was already duplicated in i915 and gma500 drivers. The gma500 one was taken