Re: [PATCH -next] drm/radeon/radeon_pm: use DEVICE_ATTR_RW macro

2021-06-01 Thread Christian König
Am 02.06.21 um 03:53 schrieb Alex Deucher: On Fri, May 28, 2021 at 3:18 AM YueHaibing wrote: Use DEVICE_ATTR_RW() helper instead of plain DEVICE_ATTR(), which makes the code a bit shorter and easier to read. Signed-off-by: YueHaibing I'm not convinced this really buys us anything other th

Re: [PATCH -next] drm/radeon/radeon_pm: use DEVICE_ATTR_RW macro

2021-06-01 Thread Christian König
Am 02.06.21 um 03:53 schrieb Alex Deucher: On Fri, May 28, 2021 at 3:18 AM YueHaibing wrote: Use DEVICE_ATTR_RW() helper instead of plain DEVICE_ATTR(), which makes the code a bit shorter and easier to read. Signed-off-by: YueHaibing I'm not convinced this really buys us anything other th

Re: [PATCH -next] drm/radeon/radeon_pm: use DEVICE_ATTR_RW macro

2021-06-01 Thread Alex Deucher
On Fri, May 28, 2021 at 3:18 AM YueHaibing wrote: > > Use DEVICE_ATTR_RW() helper instead of plain DEVICE_ATTR(), > which makes the code a bit shorter and easier to read. > > Signed-off-by: YueHaibing I'm not convinced this really buys us anything other than code churn, but I don't have a partic