Re: [PATCH] video: hgafb: correctly handle card detect failure during probe

2021-05-20 Thread Anirudh Rayabharam
On Mon, May 17, 2021 at 12:57:14AM +0530, Anirudh Rayabharam wrote: > The return value of hga_card_detect() is not properly handled causing > the probe to succeed even though hga_card_detect() failed. Since probe > succeeds, hgafb_open() can be called which will end up operating on an > unmapped hg

Re: [PATCH] video: hgafb: correctly handle card detect failure during probe

2021-05-20 Thread Greg Kroah-Hartman
On Thu, May 20, 2021 at 07:10:39PM +0530, Anirudh Rayabharam wrote: > On Mon, May 17, 2021 at 12:57:14AM +0530, Anirudh Rayabharam wrote: > > The return value of hga_card_detect() is not properly handled causing > > the probe to succeed even though hga_card_detect() failed. Since probe > > succeeds

Re: [PATCH] video: hgafb: correctly handle card detect failure during probe

2021-05-17 Thread Igor Torrente
Hi, On 5/16/21 4:27 PM, Anirudh Rayabharam wrote: The return value of hga_card_detect() is not properly handled causing the probe to succeed even though hga_card_detect() failed. Since probe succeeds, hgafb_open() can be called which will end up operating on an unmapped hga_vram. This results in