Re: [PATCH] video: fbdev: cirrusfb: check pixclock to avoid divide by zero

2021-10-27 Thread George Kennedy
On 10/27/2021 2:53 AM, Geert Uytterhoeven wrote: Hi George, On Wed, Oct 27, 2021 at 3:13 AM George Kennedy wrote: On 10/26/2021 1:12 PM, Geert Uytterhoeven wrote: On Tue, Oct 26, 2021 at 5:48 PM George Kennedy wrote: On 10/26/2021 10:11 AM, Geert Uytterhoeven wrote: On Tue, Oct 26, 2021

Re: [PATCH] video: fbdev: cirrusfb: check pixclock to avoid divide by zero

2021-10-27 Thread George Kennedy
On 10/27/2021 2:53 AM, Geert Uytterhoeven wrote: Hi George, On Wed, Oct 27, 2021 at 3:13 AM George Kennedy wrote: On 10/26/2021 1:12 PM, Geert Uytterhoeven wrote: On Tue, Oct 26, 2021 at 5:48 PM George Kennedy wrote: On 10/26/2021 10:11 AM, Geert Uytterhoeven wrote: On Tue, Oct 26, 2021

Re: [PATCH] video: fbdev: cirrusfb: check pixclock to avoid divide by zero

2021-10-26 Thread Geert Uytterhoeven
Hi George, On Wed, Oct 27, 2021 at 3:13 AM George Kennedy wrote: > On 10/26/2021 1:12 PM, Geert Uytterhoeven wrote: > > On Tue, Oct 26, 2021 at 5:48 PM George Kennedy > > wrote: > >> On 10/26/2021 10:11 AM, Geert Uytterhoeven wrote: > >>> On Tue, Oct 26, 2021 at 3:38 PM George Kennedy > >>> wro

Re: [PATCH] video: fbdev: cirrusfb: check pixclock to avoid divide by zero

2021-10-26 Thread George Kennedy
Hi Geert, On 10/26/2021 1:12 PM, Geert Uytterhoeven wrote: Hi George, On Tue, Oct 26, 2021 at 5:48 PM George Kennedy wrote: On 10/26/2021 10:11 AM, Geert Uytterhoeven wrote: On Tue, Oct 26, 2021 at 3:38 PM George Kennedy wrote: On 10/26/2021 4:30 AM, Geert Uytterhoeven wrote: On Mon, Oct

Re: [PATCH] video: fbdev: cirrusfb: check pixclock to avoid divide by zero

2021-10-26 Thread Geert Uytterhoeven
Hi George, On Tue, Oct 26, 2021 at 5:48 PM George Kennedy wrote: > On 10/26/2021 10:11 AM, Geert Uytterhoeven wrote: > > On Tue, Oct 26, 2021 at 3:38 PM George Kennedy > > wrote: > >> On 10/26/2021 4:30 AM, Geert Uytterhoeven wrote: > >>> On Mon, Oct 25, 2021 at 9:37 PM George Kennedy > >>> wro

Re: [PATCH] video: fbdev: cirrusfb: check pixclock to avoid divide by zero

2021-10-26 Thread George Kennedy
Hi Geert, On 10/26/2021 10:11 AM, Geert Uytterhoeven wrote: Hi George, On Tue, Oct 26, 2021 at 3:38 PM George Kennedy wrote: On 10/26/2021 4:30 AM, Geert Uytterhoeven wrote: On Mon, Oct 25, 2021 at 9:37 PM George Kennedy wrote: On 10/25/2021 3:07 PM, Greg KH wrote: On Mon, Oct 25, 2021 at

Re: [PATCH] video: fbdev: cirrusfb: check pixclock to avoid divide by zero

2021-10-26 Thread Geert Uytterhoeven
Hi George, On Tue, Oct 26, 2021 at 3:38 PM George Kennedy wrote: > On 10/26/2021 4:30 AM, Geert Uytterhoeven wrote: > > On Mon, Oct 25, 2021 at 9:37 PM George Kennedy > > wrote: > >> On 10/25/2021 3:07 PM, Greg KH wrote: > >>> On Mon, Oct 25, 2021 at 02:01:30PM -0500, George Kennedy wrote: > >>>

Re: [PATCH] video: fbdev: cirrusfb: check pixclock to avoid divide by zero

2021-10-26 Thread George Kennedy
Hi Geert, On 10/26/2021 4:30 AM, Geert Uytterhoeven wrote: Hi George, On Mon, Oct 25, 2021 at 9:37 PM George Kennedy wrote: On 10/25/2021 3:07 PM, Greg KH wrote: On Mon, Oct 25, 2021 at 02:01:30PM -0500, George Kennedy wrote: Do a sanity check on pixclock value before using it as a divisor.

Re: [PATCH] video: fbdev: cirrusfb: check pixclock to avoid divide by zero

2021-10-26 Thread Geert Uytterhoeven
Hi George, On Mon, Oct 25, 2021 at 9:37 PM George Kennedy wrote: > On 10/25/2021 3:07 PM, Greg KH wrote: > > On Mon, Oct 25, 2021 at 02:01:30PM -0500, George Kennedy wrote: > >> Do a sanity check on pixclock value before using it as a divisor. > >> > >> Syzkaller reported a divide error in cirrus

Re: [PATCH] video: fbdev: cirrusfb: check pixclock to avoid divide by zero

2021-10-25 Thread Zheyu Ma
On Tue, Oct 26, 2021 at 5:45 AM Sam Ravnborg wrote: > > Hi George, > > On Mon, Oct 25, 2021 at 03:33:43PM -0400, George Kennedy wrote: > > > > > > On 10/25/2021 3:07 PM, Greg KH wrote: > > > On Mon, Oct 25, 2021 at 02:01:30PM -0500, George Kennedy wrote: > > > > Do a sanity check on pixclock value

Re: [PATCH] video: fbdev: cirrusfb: check pixclock to avoid divide by zero

2021-10-25 Thread Sam Ravnborg
Hi George, On Mon, Oct 25, 2021 at 03:33:43PM -0400, George Kennedy wrote: > > > On 10/25/2021 3:07 PM, Greg KH wrote: > > On Mon, Oct 25, 2021 at 02:01:30PM -0500, George Kennedy wrote: > > > Do a sanity check on pixclock value before using it as a divisor. > > > > > > Syzkaller reported a div

Re: [PATCH] video: fbdev: cirrusfb: check pixclock to avoid divide by zero

2021-10-25 Thread George Kennedy
On 10/25/2021 3:07 PM, Greg KH wrote: On Mon, Oct 25, 2021 at 02:01:30PM -0500, George Kennedy wrote: Do a sanity check on pixclock value before using it as a divisor. Syzkaller reported a divide error in cirrusfb_check_pixclock. divide error: [#1] SMP KASAN PTI CPU: 0 PID: 14938 Comm:

Re: [PATCH] video: fbdev: cirrusfb: check pixclock to avoid divide by zero

2021-10-25 Thread Greg KH
On Mon, Oct 25, 2021 at 02:01:30PM -0500, George Kennedy wrote: > Do a sanity check on pixclock value before using it as a divisor. > > Syzkaller reported a divide error in cirrusfb_check_pixclock. > > divide error: [#1] SMP KASAN PTI > CPU: 0 PID: 14938 Comm: cirrusfb_test Not tainted 5.15.